From f44edd407bf674bfad11accad8319d5f66110b44 Mon Sep 17 00:00:00 2001 From: Christian Helmuth Date: Fri, 22 Dec 2017 09:31:36 +0100 Subject: [PATCH] run: fix import_from_depot for variable args Apply the approach to join the argument list 'args' to pass a single list argument to _collect_from_depot. Actually, this story teaches me to shy away from {*} because of its special semantics, which are {*} makes each item in a list an individual argument of the current command (https://wiki.tcl.tk/17158) This is a direct follow up to "run: let import_from_depot accept list variables", which broke calling import_from_depot with a number of individual arguments. Issue #2619 --- tool/run/depot.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tool/run/depot.inc b/tool/run/depot.inc index 7d43e371df..e34c9ed2e5 100644 --- a/tool/run/depot.inc +++ b/tool/run/depot.inc @@ -204,7 +204,7 @@ proc _collect_from_depot { archives } { # proc import_from_depot { args } { - foreach subdir [_collect_from_depot {*}$args] { + foreach subdir [_collect_from_depot [join $args " "]] { # prevent src, api, and pkg archives from inflating the boot image if {[regexp [_depot_archive_versioned_path_pattern] $subdir dummy user type]} {