ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-18 21:27:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nitpicker: restore Capture::Session::screen_size

Browse Source 
Since #5352, the 'screen_size' RPC function returns a rectangle clipped
against the client's bounding box, which unfortunately prevents
screen-capturing applications from determining the actual screen size.
This patch restores the original behavior by clipping the panorama
against client-specific constraints w/o clipping against the client's
buffer size.

Fixes #5365
This commit is contained in:
Norman Feske 2024-10-22 12:20:48 +02:00 committed by Christian Helmuth
parent 7e9c1ca3ca
commit f30bbb1472
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
repos/os/src/server/nitpicker/capture_session.h
View File

@ -203,7 +203,12 @@ class Nitpicker::Capture_session : public Session_object<Capture::Session>
Area screen_size() const override Area screen_size() const override
{ {
return Rect::intersect(_view_stack.bounding_box(), bounding_box()).area; Rect const panorama = _view_stack.bounding_box();
Rect const policy { _anchor_point(),
{ .w = _policy.w.or_default(panorama.w()),
.h = _policy.h.or_default(panorama.h()) } };
return Rect::intersect(panorama, policy).area;
} }
void screen_size_sigh(Signal_context_capability sigh) override void screen_size_sigh(Signal_context_capability sigh) override

3
repos/os/src/server/nitpicker/main.cc
View File

@ -292,6 +292,9 @@ class Nitpicker::Capture_root : public Root_component<Capture_session>
}, },
[&] { session.apply_policy(Policy::blocked()); }); }); [&] { session.apply_policy(Policy::blocked()); }); });
} }
_sessions.for_each([&] (Capture_session &session) {
session.screen_size_changed(); });
} }
/** /**