From eff90d759f9ebaa9593215d558e1f50023df12cc Mon Sep 17 00:00:00 2001 From: Emery Hemingway Date: Tue, 1 Nov 2016 19:13:17 +0100 Subject: [PATCH] remove global namespacing from internal base headers Making the Genode namespace global can cause name collisions on base-linux. Fix #2158 --- repos/base/src/include/base/internal/output.h | 6 +++--- repos/base/src/lib/base/raw_output.cc | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/repos/base/src/include/base/internal/output.h b/repos/base/src/include/base/internal/output.h index 43c51e467f..a7ececba32 100644 --- a/repos/base/src/include/base/internal/output.h +++ b/repos/base/src/include/base/internal/output.h @@ -17,8 +17,6 @@ #include -using namespace Genode; - /** * Convert digit to ASCII value @@ -114,6 +112,8 @@ static inline void out_unsigned(T value, unsigned base, int pad, template static inline void out_float(T value, unsigned base, unsigned length, OUT_CHAR_FN const &out_char) { + using namespace Genode; + /* set flag if value is negative */ int neg = value < 0 ? 1 : 0; @@ -154,7 +154,7 @@ namespace Genode { template class Buffered_output; } * The 'WRITE_FN' functor is called with a null-terminated 'char const *' * as argument. */ -template +template class Genode::Buffered_output : public Output { private: diff --git a/repos/base/src/lib/base/raw_output.cc b/repos/base/src/lib/base/raw_output.cc index 915186dc3d..56479a1253 100644 --- a/repos/base/src/lib/base/raw_output.cc +++ b/repos/base/src/lib/base/raw_output.cc @@ -19,10 +19,8 @@ #include #include -using namespace Genode; - -Output &Raw::_output() +Genode::Output &Genode::Raw::_output() { struct Write_fn { void operator () (char const *s) { raw_write_string(s); } };