ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-05-29 13:44:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vfs/pipe: fix dangling read_ready_waiters element

Browse Source 
This patch removes the obsolete 'io_progress_elem', which was wrongly
enqueued to the 'read_ready_waiters' fifo and not dequeued at
destruction time.

Fixes #4987
This commit is contained in:
Norman Feske 2023-09-12 14:37:27 +02:00 committed by Christian Helmuth
parent 458206b11a
commit e8059ccba5
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
repos/gems/src/lib/vfs/pipe/plugin.cc
View File

@ -49,8 +49,7 @@ struct Vfs_pipe::Pipe_handle : Vfs::Vfs_handle, private Pipe_handle_registry_ele
{ {
Pipe &pipe; Pipe &pipe;
Handle_element io_progress_elem { *this }; Handle_element read_ready_elem { *this };
Handle_element read_ready_elem { *this };
bool const writer; bool const writer;
@ -217,7 +216,7 @@ struct Vfs_pipe::Pipe
return Write_result::WRITE_OK; return Write_result::WRITE_OK;
} }
Read_result read(Pipe_handle &handle, Byte_range_ptr const &dst, size_t &out_count) Read_result read(Pipe_handle &, Byte_range_ptr const &dst, size_t &out_count)
{ {
size_t out = 0; size_t out = 0;
@ -235,7 +234,6 @@ struct Vfs_pipe::Pipe
if ((num_writers == 0) && !waiting_for_writers) if ((num_writers == 0) && !waiting_for_writers)
return Read_result::READ_OK; /* EOF */ return Read_result::READ_OK; /* EOF */
read_ready_waiters.enqueue(handle.io_progress_elem);
return Read_result::READ_QUEUED; return Read_result::READ_QUEUED;
} }