ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-01-19 11:16:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dde_linux: fix Intel Intel AX211 wifi without MSI-X

Browse Source 
Lack of MSI-X support in DDE Linux causes a timeout when the Intel AX211
tries to call back into the driver while loading the PNVM file while
interrupts are still disabled.

With the patch picked up from QubesOS the card works on an X1 Nano G2:
5fcfe0f19e

Issue #4663
This commit is contained in:
Benjamin Lamowski 2022-11-07 12:36:58 +01:00 committed by Christian Helmuth
parent 04efe88044
commit e46a7dd6f5
3 changed files with 48 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
repos/dde_linux/patches/iwlwifi_enable_irq_before_pnvm.patch Normal file
View File

@ -0,0 +1,46 @@
From b4024bb479b2ee9b34125b65472a0537043c8dc4 Mon Sep 17 00:00:00 2001
From: Chris Rogers <crogers122@gmail.com>
Date: Thu, 1 Sep 2022 15:56:14 +0200
Subject: [PATCH] Re-enable interrupts before loading PNVM.
For cards in the AX210+ family that advertise a SKU and try to load a PNVM,
in the non-MSIX (MSI) case the normal firmware load flow disables all interrupts
from the card except ALIVE and RX. This is primarily to enforce the driver's
assumption that we will not receive RF_KILL before the firmware has finished
loading, or else an unintelligible error is dumped.
This unfortunately also prevents us from responding to an interrupt from the
card after 'kicking the doorbell' (UREG_DOORBELL_TO_ISR6_PNVM). We therefore
wait until the specified timeout and report "Timeout waiting for PNVM load!"
and fail out of driver initialization.
This patch re-enables interrupts prior to loading the PNVM so we can respond
properly when the card notifies us of a successful PNVM load. Since the FW is
technically 'ALIVE' at this point, it should be ok to also re-enable RF_KILL.
---
drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index f041e77af059..ec982ddce196 100644
--- src/linux/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ src/linux/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -404,6 +404,15 @@ static int iwl_mvm_load_ucode_wait_alive(struct iwl_mvm *mvm,
return -EIO;
}
+ /*
+ * re-enable interrupts so we can get a response from
+ * the card when kicking the doorbell during pnvm load.
+ * This is only needed in the non-msix case. FW is
+ * technically alive at this point so re-enabling rf-kill
+ * interrupt is probably ok.
+ */
+ iwl_trans_interrupts(mvm->trans, true);
+
ret = iwl_pnvm_load(mvm->trans, &mvm->notif_wait);
if (ret) {
IWL_ERR(mvm, "Timeout waiting for PNVM load!\n");
--
2.35.3

2
repos/dde_linux/ports/linux.hash
View File

@ -1 +1 @@
340e0ebc16b91aab3ff33d3d03611dcddd02d450
3258c9b6efca7364b55b34139f0f4333c3eab88d

2
repos/dde_linux/ports/linux.port
View File

@ -9,7 +9,7 @@ DIR(linux) := src/linux
#
# Patches
#
PATCH_FILES := i915_irq.patch i915_alderlake.patch xhci_abort_ring.patch
PATCH_FILES := i915_irq.patch i915_alderlake.patch xhci_abort_ring.patch iwlwifi_enable_irq_before_pnvm.patch
PATCHES += $(addprefix patches/,$(PATCH_FILES))
# i915