ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-02-20 17:52:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

monitor: prevent overlapping region list entries

Browse Source 
Issue #5046
This commit is contained in:
Christian Prochaska 2023-11-03 14:56:52 +01:00 committed by Christian Helmuth
parent 4962340985
commit e309c38263
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
repos/os/src/monitor/monitored_region_map.h
View File

@ -156,6 +156,32 @@ struct Monitor::Monitored_region_map : Monitored_rpc_object<Region_map>
enum { PAGE_SIZE_LOG2 = 12 };
region_size = align_addr(region_size, PAGE_SIZE_LOG2);
/*
* It can happen that previous attachments got implicitly
* removed by destruction of the dataspace without knowledge
* of the monitor. The newly obtained region could then
* overlap with outdated region list entries which must
* be removed before inserting the new region.
*/
addr_t start_addr = (addr_t)attached_addr;
addr_t end_addr = start_addr + region_size - 1;
for (Region *region = _regions.first(); region; ) {
if ((region->addr <= end_addr) &&
((region->addr + region->size - 1) >= start_addr)) {
Region *next_region = region->next();
_regions.remove(region);
destroy(_alloc, region);
region = next_region;
continue;
}
region = region->next();
}
_regions.insert(new (_alloc) Region(ds, (addr_t)attached_addr,
region_size, writeable));
return attached_addr;