ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-02-21 10:01:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

libc: resolve circular dependency in fork

Browse Source 
This patch is a follow-up for the commit "libc: use monitor for fork".
It removes the use of the monitor mechanism from the
'Local_clone_service::close' RPC function because the fork_ep must stay
responsive for the destruction and creation of 'Child' objects.

Issue #3874
This commit is contained in:
Norman Feske 2020-09-18 13:39:52 +02:00 committed by Christian Helmuth
parent 274f306315
commit e0d9a04f67
1 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
repos/libports/src/lib/libc/fork.cc
View File

@ -354,32 +354,41 @@ struct Libc::Local_clone_service : Noncopyable
typedef Local_service<Session> Service; typedef Local_service<Session> Service;
Child_ready &_child_ready;
Io_signal_handler<Local_clone_service> _child_ready_handler;
void _handle_child_ready()
{
_child_ready.child_ready();
monitor().trigger_monitor_examination();
}
struct Factory : Local_service<Session>::Factory struct Factory : Local_service<Session>::Factory
{ {
Session &_session; Session &_session;
Child_ready &_child_ready; Signal_context_capability _started_sigh;
Factory(Session &session, Child_ready &child_ready) Factory(Session &session, Signal_context_capability started_sigh)
: _session(session), _child_ready(child_ready) { } : _session(session), _started_sigh(started_sigh) { }
Session &create(Args const &, Affinity) override { return _session; } Session &create(Args const &, Affinity) override { return _session; }
void upgrade(Session &, Args const &) override { } void upgrade(Session &, Args const &) override { }
void destroy(Session &) override void destroy(Session &) override { Signal_transmitter(_started_sigh).submit(); }
{
monitor().monitor([&] {
_child_ready.child_ready();
return Fn::COMPLETE;
});
}
} _factory; } _factory;
Service service { _factory }; Service service { _factory };
Local_clone_service(Env &env, Entrypoint &ep, Child_ready &child_ready) Local_clone_service(Env &env, Entrypoint &ep, Child_ready &child_ready)
: _session(env, ep), _factory(_session, child_ready) { } :
_session(env, ep), _child_ready(child_ready),
_child_ready_handler(env.ep(), *this, &Local_clone_service::_handle_child_ready),
_factory(_session, _child_ready_handler)
{ }
}; };