ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-04-13 22:23:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some signed/unsigned implicit conversions.

Browse Source 
Fix some trivial cases where the signedness of the constant value does
not match the signedness of type the code expects to see. GCC can be
asked to warn about those by passing Wsign-covnersion flag.

Issue #4354
This commit is contained in:
Piotr Tworek 2021-12-18 22:49:54 +01:00 committed by Christian Helmuth
parent f2dab083f6
commit d610f9f4f1
7 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
repos/base/include/spec/arm/cpu/consts.h
View File

@ -23,7 +23,7 @@ namespace Abi {
* change the stack pointer, we need no further stack adjustment.
*/
inline Genode::addr_t stack_align(Genode::addr_t addr) {
return (addr & ~0xf); }
return (addr & ~0xfUL); }
/**
* Do ABI specific initialization to a freshly created stack

2
repos/base/include/spec/arm_64/cpu/consts.h
View File

@ -22,7 +22,7 @@ namespace Abi {
* On ARM we align the stack top to 16-byte.
*/
inline Genode::addr_t stack_align(Genode::addr_t addr) {
return (addr & ~0xf); }
return (addr & ~0xfUL); }
/**
* Do ABI specific initialization to a freshly created stack

2
repos/base/src/include/base/internal/ipc_server.h
View File

@ -33,7 +33,7 @@ namespace Genode {
struct Rpc_request
{
Reply_capability caller { };
unsigned long badge = ~0;
unsigned long badge = ~0UL;
Rpc_request() { }

2
repos/base/src/include/base/internal/output.h
View File

@ -146,7 +146,7 @@ static inline void out_float(T value, unsigned base, unsigned length, OUT_CHAR_F
volatile_value = (T)(volatile_value - (T)integer);
volatile_value = (T)(volatile_value * (T)base);
integer = (int64_t)volatile_value;
integer = (uint64_t)volatile_value;
out_char(ascii((int)integer));
length--;

2
repos/base/src/lib/base/allocator_avl.cc
View File

@ -99,7 +99,7 @@ Allocator_avl_base::Alloc_md_result Allocator_avl_base::_alloc_block_metadata()
{
return _md_alloc.try_alloc(sizeof(Block)).convert<Alloc_md_result>(
[&] (void *ptr) {
return construct_at<Block>(ptr, 0, 0, 0); },
return construct_at<Block>(ptr, 0U, 0U, 0); },
[&] (Alloc_error error) {
return error; });
}

4
repos/base/src/lib/base/heap.cc
View File

@ -130,7 +130,7 @@ Heap::_allocate_dataspace(size_t size, bool enforce_separate_metadata)
/* add new local address range to our local allocator */
_alloc->add_range((addr_t)attach_guard.ptr, size).with_result(
[&] (Range_allocator::Range_ok) {
metadata = _alloc->alloc_aligned(sizeof(Heap::Dataspace), log2(16)); },
metadata = _alloc->alloc_aligned(sizeof(Heap::Dataspace), log2(16U)); },
[&] (Alloc_error error) {
metadata = error; });
}
@ -153,7 +153,7 @@ Heap::_allocate_dataspace(size_t size, bool enforce_separate_metadata)
Allocator::Alloc_result Heap::_try_local_alloc(size_t size)
{
return _alloc->alloc_aligned(size, log2(16)).convert<Alloc_result>(
return _alloc->alloc_aligned(size, log2(16U)).convert<Alloc_result>(
[&] (void *ptr) {
_quota_used += size;

2
repos/os/src/lib/sandbox/utils.h
View File

@ -167,7 +167,7 @@ namespace Sandbox {
*/
inline Prio_levels prio_levels_from_xml(Xml_node const &config)
{
long const prio_levels = config.attribute_value("prio_levels", 0UL);
long const prio_levels = config.attribute_value("prio_levels", 0L);
if (prio_levels && ((prio_levels >= (long)sizeof(prio_levels)*8) ||
(prio_levels != (1L << log2(prio_levels))))) {