ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-16 06:08:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Mark warnings from the signal dispatcher as such

Browse Source
This commit is contained in:
Christian Helmuth
2016-12-16 21:18:16 +01:00
committed by Norman Feske
parent e93fe55e54
commit ce3d10465e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
repos/base/include/base/signal.h
View File

@ -403,7 +403,7 @@ struct Genode::Signal_dispatcher_base : Signal_context
*/ */
template <typename T> template <typename T>
class Genode::Signal_dispatcher : public Signal_dispatcher_base, class Genode::Signal_dispatcher : public Signal_dispatcher_base,
public Signal_context_capability public Signal_context_capability
{ {
private: private:
@ -431,7 +431,7 @@ class Genode::Signal_dispatcher : public Signal_dispatcher_base,
~Signal_dispatcher() { sig_rec.dissolve(this); } ~Signal_dispatcher() { sig_rec.dissolve(this); }
void dispatch(unsigned num) { (obj.*member)(num); } void dispatch(unsigned num) override { (obj.*member)(num); }
}; };
@ -470,7 +470,7 @@ struct Genode::Signal_handler : Genode::Signal_dispatcher_base,
/** /**
* Interface of Signal_dispatcher_base * Interface of Signal_dispatcher_base
*/ */
void dispatch(unsigned num) { (obj.*member)(); } void dispatch(unsigned num) override { (obj.*member)(); }
}; };
#endif /* _INCLUDE__BASE__SIGNAL_H_ */ #endif /* _INCLUDE__BASE__SIGNAL_H_ */

6
repos/base/src/lib/base/signal.cc
View File

@ -284,12 +284,12 @@ void Signal_receiver::dispatch_signals(Signal_source *signal_source)
Signal_context *context = (Signal_context *)(source_signal.imprint()); Signal_context *context = (Signal_context *)(source_signal.imprint());
if (!context) { if (!context) {
error("received null signal imprint, stop signal handling"); error("received null signal imprint, stop signal dispatcher");
sleep_forever(); sleep_forever();
} }
if (!signal_context_registry()->test_and_lock(context)) { if (!signal_context_registry()->test_and_lock(context)) {
warning("encountered dead signal context"); warning("encountered dead signal context ", context, " in signal dispatcher");
continue; continue;
} }
@ -298,7 +298,7 @@ void Signal_receiver::dispatch_signals(Signal_source *signal_source)
Signal::Data signal(context, source_signal.num()); Signal::Data signal(context, source_signal.num());
context->_receiver->local_submit(signal); context->_receiver->local_submit(signal);
} else { } else {
warning("signal context with no receiver"); warning("signal context ", context, " with no receiver in signal dispatcher");
} }
/* free context lock that was taken by 'test_and_lock' */ /* free context lock that was taken by 'test_and_lock' */