ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-22 08:50:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

base: drop Trace::Session_component::_parent_levels

Browse Source 
Clang correctly asserts this private member variable is not used
anywhere in the code. I'm not sure what the intention of the code is,
might be this is a part of some unfinished feature. This patch just does
the minimum amount of work to allow the code to build with clang. If
required I can also drop the parent_levels constructor argument and
clean up the call sites.

Issue #3950
This commit is contained in:
Piotr Tworek
2020-11-04 00:26:22 +01:00
committed by Christian Helmuth
parent c0309a634e
commit cc193a9155
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
repos/base/src/core/include/trace/session_component.h
View File

@ -41,7 +41,6 @@ class Genode::Trace::Session_component
Sliced_heap _md_alloc { _ram, _local_rm }; Sliced_heap _md_alloc { _ram, _local_rm };
Tslab<Trace::Subject, 4096> _subjects_slab; Tslab<Trace::Subject, 4096> _subjects_slab;
Tslab<Trace::Policy, 4096> _policies_slab; Tslab<Trace::Policy, 4096> _policies_slab;
unsigned const _parent_levels;
Source_registry &_sources; Source_registry &_sources;
Policy_registry &_policies; Policy_registry &_policies;
Subject_registry _subjects; Subject_registry _subjects;

3
repos/base/src/core/trace_session_component.cc
View File

@ -173,7 +173,7 @@ Session_component::Session_component(Rpc_entrypoint &ep,
Ram_allocator &ram, Ram_allocator &ram,
Region_map &local_rm, Region_map &local_rm,
size_t arg_buffer_size, size_t arg_buffer_size,
unsigned parent_levels, unsigned /* parent_levels */,
Source_registry &sources, Source_registry &sources,
Policy_registry &policies) Policy_registry &policies)
: :
@ -182,7 +182,6 @@ Session_component::Session_component(Rpc_entrypoint &ep,
_local_rm(local_rm), _local_rm(local_rm),
_subjects_slab(&_md_alloc), _subjects_slab(&_md_alloc),
_policies_slab(&_md_alloc), _policies_slab(&_md_alloc),
_parent_levels(parent_levels),
_sources(sources), _sources(sources),
_policies(policies), _policies(policies),
_subjects(_subjects_slab, _sources), _subjects(_subjects_slab, _sources),