From ba6c4a664f6f552d685de89541d8655fd53095e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josef=20S=C3=B6ntgen?= Date: Mon, 8 Mar 2021 14:38:00 +0100 Subject: [PATCH] mixer: use audible default settings In case there is no valid configuration the component used to mute output by default. This, however, might lead to the assumption that audio is not working at all. Instead set the master output volume to 50% and the per application volume to 100%. Fixes #4043. --- repos/os/src/server/mixer/mixer.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/repos/os/src/server/mixer/mixer.cc b/repos/os/src/server/mixer/mixer.cc index 2587fc874a..e354f76399 100644 --- a/repos/os/src/server/mixer/mixer.cc +++ b/repos/os/src/server/mixer/mixer.cc @@ -169,9 +169,9 @@ class Audio_out::Mixer /* * Default settings used as fallback for new sessions */ - float _default_out_volume { 0.f }; - float _default_volume { 0.f }; - bool _default_muted { true }; + float _default_out_volume { 0.5f }; + float _default_volume { 1.0f }; + bool _default_muted { false }; /** * Remix all exception @@ -454,7 +454,7 @@ class Audio_out::Mixer "muted: ", _default_muted); } - } catch (...) { Genode::warning("could not read mixer default values"); } + } catch (...) { Genode::warning("config invalid"); } } /**