From b05b5616c8545f0f01600407c3828cebad2d26ab Mon Sep 17 00:00:00 2001 From: Martin Stein Date: Thu, 2 Mar 2017 18:42:04 +0100 Subject: [PATCH] x86 cpu_quota: lower error tolerance Previously, on X86, the timer driver used the PIT with a maximum timeout of 54 ms. Thus, the driver frequently interrupted the counters with highest priority to update the timer. This is why we needed a higher error tolerance as for ARM where the driver, once configured, can sleep for the whole test timeout. Now, we use the kernel timer and the problem seems to be exits no longer. Ref #2304 --- repos/os/run/cpu_quota.run | 9 --------- 1 file changed, 9 deletions(-) diff --git a/repos/os/run/cpu_quota.run b/repos/os/run/cpu_quota.run index cafdd7ffe0..f89083fff0 100644 --- a/repos/os/run/cpu_quota.run +++ b/repos/os/run/cpu_quota.run @@ -139,15 +139,6 @@ proc check_counter { name opt cnt total_cnt } { set tol 0.01 set is 0 - # - # On X86, the timer driver uses the PIT with a maximum timeout of 54 ms. - # Thus, the driver frequently interrupts the counters with highest - # priority to update the timer. This is why we need a higher error - # tolerance as for ARM where the driver, once configured, can sleep for - # the whole test timeout. - # - if {[have_spec x86]} { set tol 0.02 } - # # Zynq is currently tested merely in Qemu and most likely because of # that, the results are less precise.