ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-03-21 03:25:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nitpicker: avoid mode switches on driver restarts

Browse Source 
This patch retains the buffer size of the last capture client as mode as
long as no capture client exists. This avoids intermediate mode changes
in situations like suspend/resume where the display driver is restarted.

Issue #5187
This commit is contained in:
Norman Feske 2024-04-19 16:41:00 +02:00 committed by Christian Helmuth
parent 02efe59cdd
commit ad722f1450
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
repos/os/src/server/nitpicker/main.cc
View File

@ -212,6 +212,8 @@ class Nitpicker::Capture_root : public Root_component<Capture_session>
View_stack const &_view_stack;
Capture_session::Handler &_handler;
Area _fallback_bounding_box { 0, 0 };
protected:
Capture_session *_create_session(const char *args) override
@ -232,6 +234,13 @@ class Nitpicker::Capture_root : public Root_component<Capture_session>
void _destroy_session(Capture_session *session) override
{
/*
* Retain buffer size of the last vanishing session. This avoids
* mode switches when the only capture client temporarily
* disappears (driver restart).
*/
_fallback_bounding_box = session->buffer_size();
Genode::destroy(md_alloc(), session);
/* shrink screen according to the remaining output back ends */
@ -257,10 +266,13 @@ class Nitpicker::Capture_root : public Root_component<Capture_session>
*/
Area bounding_box() const
{
Area result { 0, 0 };
Area result = { 0, 0 };
bool any_session_present = false;
_sessions.for_each([&] (Capture_session const &session) {
any_session_present = true;
result = max_area(result, session.buffer_size()); });
return result;
return any_session_present ? result : _fallback_bounding_box;
}
/**