ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-19 23:53:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

os: Make Redistributor class inherit Genode::Interface.

Browse Source 
The Vmm::Gic::Gicd_banked::Redistributor is used with Constructible, but
does not have a virtual destructor even though it has virtual methods.
This prompts clang to issue the following warning:

  reconstructible.h:122:4: warning: destructor called on non-final
  'Vmm::Gic::Gicd_banked::Redistributor' that has virtual functions
  but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]

Fix this by inheriting Genode::Interface.

Issue #3984
This commit is contained in:
Piotr Tworek
2020-11-16 01:28:09 +01:00
committed by Norman Feske
parent ff28ed0f8c
commit ad4211ae2c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
repos/os/src/server/vmm/gic.h
View File

@ -134,7 +134,7 @@ class Vmm::Gic : public Vmm::Mmio_device
Genode::Constructible<Irq> _ppi[MAX_PPI]; Genode::Constructible<Irq> _ppi[MAX_PPI];
Irq::List _pending_list; Irq::List _pending_list;
struct Redistributor : Mmio_device struct Redistributor : Mmio_device, Genode::Interface
{ {
unsigned cpu_id; unsigned cpu_id;
bool last; bool last;