ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-01-18 10:46:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

base-hw scheduler: fix ready method

Browse Source 
Setting the _need_to_schedule member in the 'ready' method of the scheduler
was not done correctly. At least, the _need_to_schedule was set true in
situations were the head was not outdated by the 'ready' operation.

Ref #4151
This commit is contained in:
Martin Stein 2022-12-12 08:19:51 +01:00 committed by Christian Helmuth
parent 1151706243
commit ab298b6337
1 changed files with 23 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
repos/base-hw/src/core/kernel/cpu_scheduler.cc
View File

@ -196,43 +196,34 @@ void Cpu_scheduler::ready(Share &s)
assert(!s._ready && &s != &_idle);
s._ready = 1;
if (s._quota) {
_ucl[s._prio].remove(&s._claim_item);
if (s._claim) {
_rcl[s._prio].insert_head(&s._claim_item);
if (_head && _head_claims) {
if (s._prio >= _head->_prio) {
_need_to_schedule = true;
}
} else {
_need_to_schedule = true;
}
} else {
_rcl[s._prio].insert_tail(&s._claim_item);;
}
}
s._fill = _fill;
_fills.insert_tail(&s._fill_item);
if (!_head || _head == &_idle) {
if (_head == &_idle)
_need_to_schedule = true;
if (!s._quota)
return;
_ucl[s._prio].remove(&s._claim_item);
if (s._claim)
_rcl[s._prio].insert_head(&s._claim_item);
else
_rcl[s._prio].insert_tail(&s._claim_item);
/*
* Check whether we need to re-schedule
*/
if (_need_to_schedule)
return;
/* current head has no quota left */
if (!_head_claims) {
_need_to_schedule = true;
return;
}
/* if current head has different priority */
if (s._prio != _head->_prio) {
_need_to_schedule = s._prio > _head->_prio;
return;
}
/* if current head has same priority, the ready share gets active */
if (s._claim)
_need_to_schedule = true;
}