ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-21 00:23:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

base: remove Trace::Session::rule RPC function

Browse Source 
This part of the trace-session interface was merely a placeholder.

Fixes #848
This commit is contained in:
Norman Feske
2022-09-29 16:50:47 +02:00
committed by Christian Helmuth
parent 48cc52be07
commit a77ceb6871
4 changed files with 1 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
repos/base/include/trace_session/client.h
View File

@ -116,10 +116,6 @@ struct Genode::Trace::Session_client : Genode::Rpc_client<Genode::Trace::Session
void trace(Subject_id s, Policy_id p, size_t buffer_size) override { void trace(Subject_id s, Policy_id p, size_t buffer_size) override {
call<Rpc_trace>(s, p, buffer_size); } call<Rpc_trace>(s, p, buffer_size); }
void rule(Session_label const &label, Thread_name const &thread,
Policy_id policy, size_t buffer_size) override {
call<Rpc_rule>(label, thread, policy, buffer_size); }
void pause(Subject_id subject) override { void pause(Subject_id subject) override {
call<Rpc_pause>(subject); } call<Rpc_pause>(subject); }

12
repos/base/include/trace_session/trace_session.h
View File

@ -64,12 +64,6 @@ struct Genode::Trace::Session : Genode::Session
*/ */
virtual void trace(Subject_id, Policy_id, size_t buffer_size) = 0; virtual void trace(Subject_id, Policy_id, size_t buffer_size) = 0;
/**
* Install a matching rule for automatically tracing new threads
*/
virtual void rule(Session_label const &, Thread_name const &,
Policy_id, size_t buffer_size) = 0;
/** /**
* Pause generation of tracing data * Pause generation of tracing data
* *
@ -124,10 +118,6 @@ struct Genode::Trace::Session : Genode::Session
Nonexistent_policy, Nonexistent_policy,
Traced_by_other_session), Traced_by_other_session),
Subject_id, Policy_id, size_t); Subject_id, Policy_id, size_t);
GENODE_RPC_THROW(Rpc_rule, void, rule,
GENODE_TYPE_LIST(Out_of_ram, Out_of_caps),
Session_label const &, Thread_name const &,
Policy_id, size_t);
GENODE_RPC_THROW(Rpc_pause, void, pause, GENODE_RPC_THROW(Rpc_pause, void, pause,
GENODE_TYPE_LIST(Nonexistent_subject), Subject_id); GENODE_TYPE_LIST(Nonexistent_subject), Subject_id);
GENODE_RPC_THROW(Rpc_resume, void, resume, GENODE_RPC_THROW(Rpc_resume, void, resume,
@ -144,7 +134,7 @@ struct Genode::Trace::Session : Genode::Session
GENODE_TYPE_LIST(Nonexistent_subject), Subject_id); GENODE_TYPE_LIST(Nonexistent_subject), Subject_id);
GENODE_RPC_INTERFACE(Rpc_dataspace, Rpc_alloc_policy, Rpc_policy, GENODE_RPC_INTERFACE(Rpc_dataspace, Rpc_alloc_policy, Rpc_policy,
Rpc_unload_policy, Rpc_trace, Rpc_rule, Rpc_pause, Rpc_unload_policy, Rpc_trace, Rpc_pause,
Rpc_resume, Rpc_subjects, Rpc_buffer, Rpc_resume, Rpc_subjects, Rpc_buffer,
Rpc_free, Rpc_subject_infos); Rpc_free, Rpc_subject_infos);
}; };

1
repos/base/src/core/include/trace/session_component.h
View File

@ -78,7 +78,6 @@ class Genode::Trace::Session_component
Dataspace_capability policy(Policy_id) override; Dataspace_capability policy(Policy_id) override;
void unload_policy(Policy_id) override; void unload_policy(Policy_id) override;
void trace(Subject_id, Policy_id, size_t) override; void trace(Subject_id, Policy_id, size_t) override;
void rule(Session_label const &, Thread_name const &, Policy_id, size_t) override;
void pause(Subject_id) override; void pause(Subject_id) override;
void resume(Subject_id) override; void resume(Subject_id) override;
Dataspace_capability buffer(Subject_id) override; Dataspace_capability buffer(Subject_id) override;

7
repos/base/src/core/trace_session_component.cc
View File

@ -127,13 +127,6 @@ void Session_component::trace(Subject_id subject_id, Policy_id policy_id,
} }
void Session_component::rule(Session_label const &, Thread_name const &,
Policy_id, size_t)
{
/* not implemented yet */
}
void Session_component::pause(Subject_id subject_id) void Session_component::pause(Subject_id subject_id)
{ {
_subjects.lookup_by_id(subject_id).pause(); _subjects.lookup_by_id(subject_id).pause();