From 9c9f67d0d625703a51ca3be34358d08fb1f20316 Mon Sep 17 00:00:00 2001
From: Bjoern Doebel <bjoern.doebel@gmail.com>
Date: Wed, 5 Feb 2014 22:49:48 +0100
Subject: [PATCH] Check for all missing tools at once

Instead of terminating tool/tool_chain when finding the first
missing tool, this patch runs all checks to completion before
bailing out. This eases finding missing programs, because the
user has to run the script only once to get a list of all missing
software.

Fixes #1046
Fixes #1047
---
 tool/tool_chain | 46 ++++++++++++++++++++++++++--------------------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/tool/tool_chain b/tool/tool_chain
index 7029144c95..738ac3c5f1 100755
--- a/tool/tool_chain
+++ b/tool/tool_chain
@@ -94,50 +94,56 @@ AUTOCONF_gcc_4.7.2 = autoconf2.64
 
 AUTOCONF = $(AUTOCONF_gcc_$(GCC_VERSION))
 
-ifeq ($(AUTOCONF),)
-$(error Unknown autoconf version for GCC $(GCC_VERSION).)
-endif
+# Return $(2) if $(1) is empty, "" else
+check_nonempty_f = $(if $(1),,$(info $(2))$(2))
+# Return $(3) if $(1) != $(2), "" else
+check_equal_f    = $(if $(filter $(1),$(2)),,$(info $(3))$(3))
+
+AUTOCONF_OK = $(call check_nonempty_f,$(AUTOCONF),\
+                Unknown autoconf version for GCC $(GCC_VERSION))
 
 #
 # Check if 'autoconf' is installed
 #
-ifeq ($(shell which $(AUTOCONF)),)
-$(error Need to have '$(AUTOCONF)' installed.)
-endif
+AUTOCONFINST_OK = $(call check_nonempty_f,$(shell which $(AUTOCONF)),\
+                    Need to have $(AUTOCONF) installed.)
 
 #
 # Check if 'libncurses' is installed
 #
-ifneq ($(shell $(LD) -lncurses -e0 -o /tmp/a.out && echo ok),ok)
-$(error Need to have 'libncurses' installed.)
-endif
+CURSES_OK = $(call check_equal_f,\
+              $(shell $(LD) -lncurses -e0 -o /tmp/a.out && echo ok),ok,\
+              Need to have 'libncurses' installed.)
 
 #
 # Check if 'texinfo' is installed
 #
-ifeq ($(shell which texi2pdf),)
-$(error Need to have 'texinfo' installed.)
-endif
+TEXINFO_OK = $(call check_nonempty_f,$(shell which texi2pdf),\
+               Need to have 'texinfo' installed.)
 
 #
 # Check if 'wget' is installed
 #
-ifeq ($(shell which wget),)
-$(error Need to have 'wget' installed.)
-endif
+WGET_OK = $(call check_nonempty_f,$(shell which wget),\
+            Need to have 'wget' installed.)
 
 #
 # Check if 'autogen' is installed
 #
-ifeq ($(shell which autogen)),)
-$(error Need to have 'autogen' installed.)
-endif
+AUTOGEN_OK = $(call check_nonempty_f,$(shell which autogen),\
+               Need to have 'autogen' installed.)
 
 #
 # Check if 'gpg' is installed
 #
-ifeq ($(shell which gpg)),)
-$(error Need to have 'gpg' installed.)
+GPG_OK = $(call check_nonempty_f,$(shell which gpg),\
+           Need to have 'gpg' installed.)
+
+TOOLS_OK = $(AUTOCONF_OK) $(AUTOCONFINST_OK) $(CURSES_OK) \
+           $(TEXINFO_OK) $(WGET_OK) $(AUTOGEN_OK) $(GPG_OK)
+
+ifneq ($(strip $(TOOLS_OK)),)
+$(error Please install missing tools.)
 endif
 
 #