ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-01 23:20:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sandbox: prevent non-empty list model on destruction

Browse Source 
The parent-provides model is destroyed if no <parent-provides> node is
found in the configuration, which resulted in

  Warning: list model not empty at destruction time

and leaking memory for the allocated nodes. The commit now explicitly
empties the list model in the destructor of ~Parent_provides_model.

Note, the case is implicitly tested in pkg/test-init by step "denial of
forwarded session request" and <init_config version="empty">.

Thanks to Peter for reporting this issue.

Fixes #4547
This commit is contained in:
Christian Helmuth 2022-06-29 16:57:23 +02:00
parent f14b68202c
commit 9a47f7bf71
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
repos/os/recipes/pkg/test-init/runtime
View File

@ -5,6 +5,7 @@
<events> <events>
<timeout meaning="failed" sec="330" /> <timeout meaning="failed" sec="330" />
<log meaning="succeeded">child "test-init" exited with exit value 0</log> <log meaning="succeeded">child "test-init" exited with exit value 0</log>
<log meaning="failed">list model not empty at destruction time</log>
</events> </events>
<content> <content>

5
repos/os/src/lib/sandbox/config_model.h
View File

@ -73,6 +73,11 @@ struct Sandbox::Parent_provides_model : Noncopyable
_alloc(alloc), _verbose(verbose), _factory(factory) _alloc(alloc), _verbose(verbose), _factory(factory)
{ } { }
~Parent_provides_model()
{
update_from_xml(Xml_node("<empty/>"));
}
void update_from_xml(Xml_node const &xml) void update_from_xml(Xml_node const &xml)
{ {
bool first_log = true; bool first_log = true;