ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-24 07:46:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Console: avoid to use buf for '-' and '0' padding chars

Browse Source 
As buf is not sized depending on the padding, if a huge padding is put
in buf then we could see an overflow.
This commit is contained in:
Alexandre Bique 2012-02-15 06:27:36 +01:00
parent c41a2a8279
commit 9593d59b3a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
base/src/base/console/console.cc
View File

@ -188,7 +188,7 @@ void Console::_out_signed(T value, unsigned base)
/* add sign to buffer for negative values */
if (neg)
buf[i++] = '-';
_out_char('-');
/* output buffer in reverse order */
for (; i--; )
@ -223,7 +223,7 @@ void Console::_out_unsigned(T value, unsigned base, int pad)
/* add padding zeros */
for (; pad-- > 0; )
buf[i++] = ascii(0);
_out_char(ascii(0));
/* output buffer in reverse order */
for (; i--; )