ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-18 07:08:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Warn on redundant call to exec_static_constructors()

Browse Source
This commit is contained in:
Christian Helmuth
2018-04-03 17:09:47 +02:00
parent b3791fabc2
commit 92edcb17e5
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
repos/base/src/lib/ldso/main.cc
View File

@ -653,6 +653,10 @@ void Genode::init_ldso_phdr(Env &env)
void Genode::exec_static_constructors() void Genode::exec_static_constructors()
{ {
if (!binary_ptr->static_construction_pending())
warning("Don't call Genode::Env::exec_static_constructors() "
"in components without static globals");
binary_ptr->finish_static_construction(); binary_ptr->finish_static_construction();
} }

3
repos/demo/src/server/nitlog/main.cc
View File

@ -504,8 +504,5 @@ struct Nitlog::Main
void Component::construct(Genode::Env &env) void Component::construct(Genode::Env &env)
{ {
/* XXX execute constructors of global statics */
env.exec_static_constructors();
static Nitlog::Main main(env); static Nitlog::Main main(env);
} }

3
repos/os/src/server/nitpicker/main.cc
View File

@ -579,8 +579,5 @@ void Nitpicker::Main::_handle_fb_mode()
void Component::construct(Genode::Env &env) void Component::construct(Genode::Env &env)
{ {
/* XXX execute constructors of global statics */
env.exec_static_constructors();
static Nitpicker::Main nitpicker(env); static Nitpicker::Main nitpicker(env);
} }