ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-04-08 03:45:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lx_emul: use 'dma_address' in 'dma_unmap_sg_attrs'

Browse Source 
The way the 'struct page' management is currently implemented it is
not safe to rely on it in case allocations share the same page. This
is in particular true where the virtual address is obtained by
querying the page object for maintaining the CPU caches.

Issue #4813
This commit is contained in:
Josef Söntgen 2023-04-04 17:20:47 +02:00 committed by Christian Helmuth
parent 997e60d52a
commit 7b146e0563
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
repos/dde_linux/src/lib/lx_emul/shadow/kernel/dma/mapping.c
View File

@ -103,12 +103,25 @@ void dma_unmap_sg_attrs(struct device * dev,
{
int i;
struct scatterlist *sg;
unsigned long virt_addr;
if (dir != DMA_FROM_DEVICE)
return;
for_each_sg(sgl, sg, nents, i) {
lx_emul_mem_cache_invalidate(page_address(sg_page(sg)) + sg->offset,
/*
* Since calling 'dma_unmap_sg_attrs' should be inverse to
* 'dma_map_sg_attrs' we use the formerly acquired 'dma_address'
* to look up the corresponding virtual address to invalidate the
* the cache.
*/
if (!sg->dma_address)
continue;
virt_addr =
lx_emul_mem_virt_addr((void*)(sg->dma_address - sg->offset));
lx_emul_mem_cache_invalidate((void*)(virt_addr + sg->offset),
sg->length);
sg->dma_address = 0;
}
}