ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-04-07 19:34:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

monitor: remove terminal write busy loop

Browse Source 
Fixes #5011
This commit is contained in:
Christian Prochaska 2023-09-26 12:54:01 +02:00 committed by Christian Helmuth
parent 529cdc949b
commit 7731e02a20
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
repos/os/src/monitor/gdb_stub.h
View File

@ -346,7 +346,9 @@ struct qXfer : Command_with_separator
static Window from_args(Const_byte_range_ptr const &args)
{
return { .offset = comma_separated_hex_value(args, 0, 0UL),
.len = comma_separated_hex_value(args, 1, 0UL) };
/* terminal_crosslink currently buffers 4096 bytes */
.len = min(comma_separated_hex_value(args, 1, 0UL),
2048UL) };
}
};

13
repos/os/src/monitor/main.cc
View File

@ -133,14 +133,11 @@ struct Monitor::Main : Sandbox::State_handler,
Terminal::Connection &_terminal;
void operator () (char const *str)
{
for (;;) {
size_t const num_bytes = strlen(str);
size_t const written_bytes = _terminal.write(str, num_bytes);
if (written_bytes == num_bytes)
break;
str = str + written_bytes;
}
size_t const num_bytes = strlen(str);
size_t const written_bytes = _terminal.write(str, num_bytes);
if (written_bytes != num_bytes)
Genode::warning("Could not send the debug response "
"message completely.");
}
} _write_fn;