From 75111c4f1a8e6fd6caeff26a99442e637062a15e Mon Sep 17 00:00:00 2001 From: Christian Prochaska Date: Wed, 28 Oct 2015 16:14:08 +0100 Subject: [PATCH] wm: sanitize the view title By replacing '"' by ''', we work around issue #1757. --- repos/gems/src/server/wm/nitpicker.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/repos/gems/src/server/wm/nitpicker.h b/repos/gems/src/server/wm/nitpicker.h index 46f22c877a..60c37f6602 100644 --- a/repos/gems/src/server/wm/nitpicker.h +++ b/repos/gems/src/server/wm/nitpicker.h @@ -673,9 +673,18 @@ class Wm::Nitpicker::Session_component : public Rpc_object, case Command::OP_TITLE: { + char sanitized_title[command.title.title.capacity()]; + + Genode::strncpy(sanitized_title, command.title.title.string(), + sizeof(sanitized_title)); + + for (char *c = sanitized_title; *c; c++) + if (*c == '"') + *c = '\''; + Locked_ptr view(_view_handle_registry.lookup(command.title.view)); if (view.is_valid()) - view->title(command.title.title.string()); + view->title(sanitized_title); return; }