ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-04-09 04:15:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sculpt: avoid installation-complete feedback loop

Browse Source 
Issue #4820
This commit is contained in:
Norman Feske 2023-04-27 14:06:55 +02:00
parent 6d91b5d51b
commit 6717494c5b
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
repos/gems/src/app/sculpt_manager/main.cc
View File

@ -1819,22 +1819,15 @@ void Sculpt::Main::_handle_update_state()
bool const installation_complete =
!update_state.attribute_value("progress", false);
bool const popup_watches_downloads =
_popup_dialog.interested_in_download();
if (installation_complete) {
Xml_node const blueprint = _blueprint_rom.xml();
bool const new_depot_query_needed = popup_watches_downloads
|| blueprint_any_missing(blueprint)
bool const new_depot_query_needed = blueprint_any_missing(blueprint)
|| blueprint_any_rom_missing(blueprint)
|| any_completed_download;
if (new_depot_query_needed)
trigger_depot_query();
if (popup_watches_downloads)
_deploy.update_installation();
_deploy.reattempt_after_installation();
}

8
repos/gems/src/app/sculpt_manager/view/popup_dialog.h
View File

@ -425,14 +425,6 @@ struct Sculpt::Popup_dialog : Dialog
_refresh.refresh_popup_dialog();
}
bool interested_in_download() const
{
if (_state == DEPOT_SELECTION)
return true;
return _state >= PKG_REQUESTED && !_blueprint_info.ready_to_deploy();
}
bool interested_in_file_operations() const
{
return _state == DEPOT_SELECTION;