ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-19 21:57:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nic_router: find permit rules w/o exceptions

Browse Source 
Replaces the former implementation of the 'find_by_port' method at the data
structure for permit rules. This method used to return a reference to the found
object and threw an exception if no matching object was found.

The new implementation doesn't return anything and doesn't throw exceptions. It
takes two lambda arguments instead. One for handling the case that a match was
found with a reference to the matching object as argument and another for
handling the case that no object matches.

This way, expensive exception handling can be avoided and object references
stay in a local scope.

Furthermore, the commit introduces a convenience wrapper for finding the best
matching pair of transport rule and corresponding permit rule for a given
destination IP and port. This method as well follows the above mentioned
concept.

Ref #4536
This commit is contained in:
Martin Stein 2022-06-27 16:45:05 +02:00 committed by Christian Helmuth
parent 0f6714c6d7
commit 65955601f0
5 changed files with 121 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
repos/os/src/server/nic_router/interface.cc
View File

@ -1288,18 +1288,16 @@ void Interface::_handle_ip(Ethernet_frame &eth,
}
}
/* try to route via transport and permit rules */
try {
_transport_rules(local_domain, prot).find_longest_prefix_match(
_transport_rules(local_domain, prot).find_best_match(
local_id.dst_ip,
[&] /* handle_match */ (Transport_rule const &transport_rule)
local_id.dst_port,
[&] /* handle_match */ (Transport_rule const &transport_rule,
Permit_rule const &permit_rule)
{
Permit_rule const &permit_rule =
transport_rule.permit_rule(local_id.dst_port);
if(_config().verbose()) {
log("[", local_domain, "] using ",
l3_protocol_name(prot), " rule: ", transport_rule,
" ", permit_rule);
l3_protocol_name(prot), " rule: ",
transport_rule, " ", permit_rule);
}
Domain &remote_domain = permit_rule.domain();
_adapt_eth(eth, local_id.dst_ip, pkt, remote_domain);
@ -1315,8 +1313,6 @@ void Interface::_handle_ip(Ethernet_frame &eth,
return;
}
}
catch (Permit_single_rule_tree::No_match) { }
}
catch (Interface::Bad_transport_protocol) { }
/* try to route via IP rules */
@ -1932,27 +1928,24 @@ void Interface::_update_udp_tcp_links(L3_protocol prot,
try {
/* try to find transport rule that matches the server IP */
bool done { false };
_transport_rules(cln_dom, prot).find_longest_prefix_match(
_transport_rules(cln_dom, prot).find_best_match(
link.client().dst_ip(),
[&] /* handle_match */ (Transport_rule const &transport_rule)
link.client().dst_port(),
[&] /* handle_match */ (Transport_rule const &,
Permit_rule const &permit_rule)
{
/* try to find permit rule that matches the server port */
Permit_rule const &permit_rule =
transport_rule.permit_rule(link.client().dst_port());
_update_link_check_nat(link, permit_rule.domain(), prot, cln_dom);
done = true;
},
[&] /* handle_no_match */ ()
{
_dismiss_link_log(link, "no transport/forward rule");
_dismiss_link_log(link, "no matching transport/permit/forward rule");
}
);
if (done) {
return;
}
}
catch (Permit_single_rule_tree::No_match) { _dismiss_link_log(link, "no permit rule"); }
catch (Dismiss_link) { }
}
);

31
repos/os/src/server/nic_router/permit_rule.cc
View File

@ -85,34 +85,3 @@ Permit_single_rule::Permit_single_rule(Domain_tree &domains,
if (_port == Port(0) || dynamic_port(_port)) {
throw Invalid(); }
}
Permit_single_rule const &
Permit_single_rule::find_by_port(Port const port) const
{
if (port == _port) {
return *this; }
bool const side = port.value > _port.value;
Permit_single_rule *const rule = Avl_node<Permit_single_rule>::child(side);
if (!rule) {
throw Permit_single_rule_tree::No_match(); }
return rule->find_by_port(port);
}
/*****************************
** Permit_single_rule_tree **
*****************************/
Permit_single_rule const &
Permit_single_rule_tree::find_by_port(Port const port) const
{
Permit_single_rule *const rule = first();
if (!rule) {
throw No_match(); }
return rule->find_by_port(port);
}

47
repos/os/src/server/nic_router/permit_rule.h
View File

@ -112,7 +112,33 @@ class Net::Permit_single_rule : public Permit_rule,
Permit_single_rule(Domain_tree &domains,
Genode::Xml_node const node);
Permit_single_rule const &find_by_port(Port const port) const;
template <typename HANDLE_MATCH_FN,
typename HANDLE_NO_MATCH_FN>
void find_by_port(Port const port,
HANDLE_MATCH_FN && handle_match,
HANDLE_NO_MATCH_FN && handle_no_match) const
{
if (port.value != _port.value) {
Permit_single_rule *const rule_ptr {
Avl_node<Permit_single_rule>::child(
port.value > _port.value) };
if (rule_ptr != nullptr) {
rule_ptr->find_by_port(
port, handle_match, handle_no_match);
} else {
handle_no_match();
}
} else {
handle_match(*this);
}
}
/*********
@ -141,8 +167,6 @@ struct Net::Permit_single_rule_tree : private Avl_tree<Permit_single_rule>
{
friend class Transport_rule;
struct No_match : Genode::Exception { };
void insert(Permit_single_rule *rule)
{
Genode::Avl_tree<Permit_single_rule>::insert(rule);
@ -150,7 +174,22 @@ struct Net::Permit_single_rule_tree : private Avl_tree<Permit_single_rule>
using Genode::Avl_tree<Permit_single_rule>::first;
Permit_single_rule const &find_by_port(Port const port) const;
template <typename HANDLE_MATCH_FN,
typename HANDLE_NO_MATCH_FN>
void find_by_port(Port const port,
HANDLE_MATCH_FN && handle_match,
HANDLE_NO_MATCH_FN && handle_no_match) const
{
if (first() != nullptr) {
first()->find_by_port(port, handle_match, handle_no_match);
} else {
handle_no_match();
}
}
};
#endif /* _PERMIT_RULE_H_ */

8
repos/os/src/server/nic_router/transport_rule.cc
View File

@ -84,11 +84,3 @@ Transport_rule::~Transport_rule()
try { destroy(_alloc, &_permit_any_rule()); }
catch (Pointer<Permit_any_rule>::Invalid) { }
}
Permit_rule const &Transport_rule::permit_rule(Port const port) const
{
try { return _permit_any_rule(); }
catch (Pointer<Permit_any_rule>::Invalid) { }
return _permit_single_rules.find_by_port(port);
}

50
repos/os/src/server/nic_router/transport_rule.h
View File

@ -25,7 +25,7 @@ namespace Net {
class Configuration;
class Transport_rule;
struct Transport_rule_list : Direct_rule_list<Transport_rule> { };
class Transport_rule_list;
}
@ -53,7 +53,53 @@ class Net::Transport_rule : public Direct_rule<Transport_rule>
~Transport_rule();
Permit_rule const &permit_rule(Port const port) const;
template <typename HANDLE_MATCH_FN,
typename HANDLE_NO_MATCH_FN>
void
find_permit_rule_by_port(Port const port,
HANDLE_MATCH_FN && handle_match,
HANDLE_NO_MATCH_FN && handle_no_match) const
{
if (_permit_any_rule.valid()) {
handle_match(_permit_any_rule());
} else {
_permit_single_rules.find_by_port(
port, handle_match, handle_no_match);
}
}
};
class Net::Transport_rule_list : public Direct_rule_list<Transport_rule>
{
public:
template <typename HANDLE_MATCH_FN,
typename HANDLE_NO_MATCH_FN>
void find_best_match(Ipv4_address const &ip,
Port const port,
HANDLE_MATCH_FN && handle_match,
HANDLE_NO_MATCH_FN && handle_no_match) const
{
find_longest_prefix_match(
ip,
[&] /* handle_match */ (Transport_rule const &transport_rule)
{
transport_rule.find_permit_rule_by_port(
port,
[&] /* handle_match */ (Permit_rule const &permit_rule)
{
handle_match(transport_rule, permit_rule);
},
handle_no_match);
},
handle_no_match
);
}
};
#endif /* _TRANSPORT_RULE_H_ */