ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-12 04:08:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sculpt: break possible depot-query feedback loop

Browse Source 
Fixes #3436
This commit is contained in:
Norman Feske
2019-06-29 12:18:12 +02:00
committed by Christian Helmuth
parent c92a9ce591
commit 58a0f5c30b
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
repos/gems/src/app/sculpt_manager/main.cc
View File

@ -249,6 +249,16 @@ struct Sculpt::Main : Input_event_handler,
Xml_node const blueprint = _blueprint_rom.xml(); Xml_node const blueprint = _blueprint_rom.xml();
/*
* Drop intermediate results that will be superseded by a newer query.
* This is important because an outdated blueprint would be disregarded
* by 'handle_deploy' anyway while at the same time a new query is
* issued. This can result a feedback loop where blueprints are
* requested but never applied.
*/
if (blueprint.attribute_value("version", 0U) != _query_version.value)
return;
_runtime_state.apply_to_construction([&] (Component &component) { _runtime_state.apply_to_construction([&] (Component &component) {
_popup_dialog.apply_blueprint(component, blueprint); }); _popup_dialog.apply_blueprint(component, blueprint); });