ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-04-07 19:34:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tresor: don't decode superblock before hash check

Browse Source 
Superblock_control::Initialize used to decode a read superblock before checking
its hash. This is not necessary but may cause the operation to end up in a
decoding error on a superblock that is not the desired one anyway.

Ref #5077
This commit is contained in:
Martin Stein 2024-03-19 13:55:25 +01:00 committed by Christian Helmuth
parent 016a769605
commit 518c32e1af
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
repos/gems/src/lib/tresor/superblock_control.cc
View File

@ -529,8 +529,8 @@ bool Superblock_control::Initialize::execute(Execute_attr const &attr)
case READ_BLOCK: progress |= _read_block.execute(attr.block_io); break;
case READ_BLOCK_SUCCEEDED:
_sb_ciphertext.decode_from_blk(_blk);
if (check_hash(_blk, _hash)) {
_sb_ciphertext.decode_from_blk(_blk);
_gen = _sb_ciphertext.snapshots.items[_sb_ciphertext.snapshots.newest_snap_idx()].gen;
attr.sb.copy_all_but_key_values_from(_sb_ciphertext);
_decrypt_key.generate(_helper, DECRYPT_KEY, DECRYPT_CURR_KEY_SUCCEEDED, progress, attr.sb.current_key.value, _sb_ciphertext.current_key.value);