ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-05 00:50:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix: _session_list in child.h must be locked

Browse Source 
The _session_list can be modified concurrently,
so the iteration over the list must be locked.
This commit is contained in:
Alexander Boettcher 2012-06-29 14:48:26 +02:00 committed by Norman Feske
parent 1a94c3b623
commit 4d5d91efef
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
base/include/base/child.h
View File

@ -338,8 +338,6 @@ namespace Genode {
*/ */
void _remove_session(Session *s) void _remove_session(Session *s)
{ {
Lock::Guard lock_guard(_lock);
/* forget about this session */ /* forget about this session */
_session_pool.remove(s); _session_pool.remove(s);
_session_list.remove(s); _session_list.remove(s);
@ -420,8 +418,9 @@ namespace Genode {
*/ */
void revoke_server(const Server *server) void revoke_server(const Server *server)
{ {
while (1) { Lock::Guard lock_guard(_lock);
while (1) {
/* search session belonging to the specified server */ /* search session belonging to the specified server */
Session *s = _session_list.first(); Session *s = _session_list.first();
for ( ; s && (s->server() != server); s = s->next()); for ( ; s && (s->server() != server); s = s->next());
@ -575,6 +574,7 @@ namespace Genode {
} }
} }
Lock::Guard lock_guard(_lock);
_remove_session(s); _remove_session(s);
} }