ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-19 13:47:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

init: invalidate child-provided service on kill

Browse Source 
When init destroys a child server with an open session, the client must
be updated as it will otherwise store a pointer to a no-more existing
service object which will be dereferenced when the child client is
destroyed.

Fixes #1912
This commit is contained in:
Johannes Schlatow 2016-03-18 19:27:05 +01:00 committed by Christian Helmuth
parent b07be42e9f
commit 44fe44e8b6
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
repos/os/src/init/main.cc
View File

@ -231,6 +231,13 @@ class Init::Child_registry : public Name_registry, Child_list
return _aliases.first() ? _aliases.first() : 0;
}
void revoke_server(Genode::Server const *server)
{
Genode::List_element<Child> *curr = first();
for (; curr; curr = curr->next())
curr->object()->_child.revoke_server(server);
}
/*****************************
** Name-registry interface **
@ -379,7 +386,19 @@ int main(int, char **)
while (children.any()) {
Init::Child *child = children.any();
children.remove(child);
Genode::Server const *server = child->server();
destroy(env()->heap(), child);
/*
* The killed child may have provided services to other children.
* Since the server is dead by now, we cannot close its sessions
* in the cooperative way. Instead, we need to instruct each
* other child to forget about session associated with the dead
* server. Note that the 'child' pointer points a a no-more
* existing object. It is only used to identify the corresponding
* session. It must never by de-referenced!
*/
children.revoke_server(server);
}
/* remove all known aliases */