ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-01-05 13:34:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vfs_tap: prevent unnoticed link state changes

Browse Source 
Swap order of link_state() and link_state_sigh() calls in order to not
miss any link state changes.

Fixes #5316
This commit is contained in:
Johannes Schlatow 2024-08-05 13:14:39 +02:00 committed by Christian Helmuth
parent 2e92b7ae32
commit 32b7a91c19
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
repos/os/src/lib/vfs/tap/nic_file_system.h
View File

@ -60,7 +60,7 @@ class Vfs::Nic_file_system::Nic_vfs_handle : public Single_vfs_handle
Vfs::Env::User &_vfs_user; Vfs::Env::User &_vfs_user;
Nic::Packet_allocator _pkt_alloc; Nic::Packet_allocator _pkt_alloc;
Nic::Connection _nic; Nic::Connection _nic;
bool _link_state; bool _link_state { false };
bool _notifying = false; bool _notifying = false;
bool _blocked = false; bool _blocked = false;
@ -111,10 +111,10 @@ class Vfs::Nic_file_system::Nic_vfs_handle : public Single_vfs_handle
_env(env), _env(env),
_vfs_user(vfs_user), _vfs_user(vfs_user),
_pkt_alloc(&alloc), _pkt_alloc(&alloc),
_nic(_env, &_pkt_alloc, BUF_SIZE, BUF_SIZE, label.string()), _nic(_env, &_pkt_alloc, BUF_SIZE, BUF_SIZE, label.string())
_link_state(_nic.link_state())
{ {
_nic.link_state_sigh(_link_state_handler); _nic.link_state_sigh(_link_state_handler);
_link_state = _nic.link_state();
_nic.tx_channel()->sigh_ack_avail (_ack_avail_handler); _nic.tx_channel()->sigh_ack_avail (_ack_avail_handler);
_nic.rx_channel()->sigh_ready_to_ack (_read_avail_handler); _nic.rx_channel()->sigh_ready_to_ack (_read_avail_handler);
_nic.rx_channel()->sigh_packet_avail (_read_avail_handler); _nic.rx_channel()->sigh_packet_avail (_read_avail_handler);