ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-01-02 20:16:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

base: destruction of env-session-providing child

Browse Source 
This patch addresses the corner case of destructing a child that
provides an enviroment session to another child. Before this patch,
this situation could result in an infinite loop.

The problem was introduced as a side effect of issue #2197 "base: apply
routing policy to environment sessions".
This commit is contained in:
Norman Feske 2017-01-18 11:35:40 +01:00
parent 94d991277f
commit 21458e6efa
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
repos/base/src/lib/base/session_state.cc
View File

@ -73,12 +73,27 @@ void Session_state::destroy()
{ {
/* /*
* Manually release client-side ID so that static env sessions are * Manually release client-side ID so that static env sessions are
* immediately by removed from the cliend ID space when 'destroy' is * immediately removed from the client ID space when 'destroy' is
* called. Otherwise, the iterative cleanup of the cliend ID space * called. Otherwise, the iterative cleanup of the cliend ID space
* via 'apply_any' would end up in an infinite loop. * via 'apply_any' would end up in an infinite loop.
*/ */
_id_at_client.destruct(); _id_at_client.destruct();
/*
* Manually release the server-side ID of the session from server ID space
* to make sure that the iterative cleanup of child-provided sessions (in
* the 'Child' destructor) always terminates regardless of the used
* session-state factory.
*
* In particular, if the to-be-destructed child provided an environment
* session of another child, there is no factory for such an environment
* session. The server-ID destructor of such an environment session would
* be called not before destructing the corresponent 'Env_connection' of
* the client, independent from the destruction of the session-providing
* child.
*/
id_at_server.destruct();
if (_factory) if (_factory)
_factory->_destroy(*this); _factory->_destroy(*this);
} }