From 1aba8182a4d07ffd5bedd0f4ae075f80cfed0cd5 Mon Sep 17 00:00:00 2001
From: Norman Feske <norman.feske@genode-labs.com>
Date: Mon, 6 Nov 2023 12:21:59 +0100
Subject: [PATCH] dialog: pass value to Select_button::click

This eliminates the need to distinguish enum values in the body of the
handler, easing the forwarding of the selected value.

Issue #5008
Issue #5053
---
 repos/gems/include/dialog/widgets.h                   | 2 +-
 repos/gems/src/app/sculpt_manager/view/panel_dialog.h | 6 +++---
 repos/gems/src/test/dialog/main.cc                    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/repos/gems/include/dialog/widgets.h b/repos/gems/include/dialog/widgets.h
index 57768d00b6..a25832ef20 100644
--- a/repos/gems/include/dialog/widgets.h
+++ b/repos/gems/include/dialog/widgets.h
@@ -68,7 +68,7 @@ struct Dialog::Select_button : Widget<Button>
 	}
 
 	template <typename FN>
-	void click(Clicked_at const &, FN const &select_fn) { select_fn(); }
+	void click(Clicked_at const &, FN const &select_fn) { select_fn(_value); }
 };
 
 
diff --git a/repos/gems/src/app/sculpt_manager/view/panel_dialog.h b/repos/gems/src/app/sculpt_manager/view/panel_dialog.h
index 81dbc14e56..a8de150af1 100644
--- a/repos/gems/src/app/sculpt_manager/view/panel_dialog.h
+++ b/repos/gems/src/app/sculpt_manager/view/panel_dialog.h
@@ -75,9 +75,9 @@ struct Sculpt::Panel_dialog : Top_level_dialog
 		_settings_button.propagate(at, [&] { _action.toggle_settings_visibility(); });
 		_network_button .propagate(at, [&] { _action.toggle_network_visibility(); });
 		_log_button     .propagate(at, [&] { _action.toggle_log_visibility(); });
-		_files_tab      .propagate(at, [&] { _action.select_tab(Tab::FILES); });
-		_components_tab .propagate(at, [&] { _action.select_tab(Tab::COMPONENTS); });
-		_inspect_tab    .propagate(at, [&] { _action.select_tab(Tab::INSPECT); });
+		_files_tab      .propagate(at, [&] (Tab t) { _action.select_tab(t); });
+		_components_tab .propagate(at, [&] (Tab t) { _action.select_tab(t); });
+		_inspect_tab    .propagate(at, [&] (Tab t) { _action.select_tab(t); });
 	}
 
 	Panel_dialog(State const &state, Action &action)
diff --git a/repos/gems/src/test/dialog/main.cc b/repos/gems/src/test/dialog/main.cc
index 41fbf37905..20423557d7 100644
--- a/repos/gems/src/test/dialog/main.cc
+++ b/repos/gems/src/test/dialog/main.cc
@@ -101,8 +101,8 @@ struct Dialog_test::Main
 			_inspect.propagate(at, [&] { log("inspect activated!"); });
 			_confirm.propagate(at);
 			_cancel .propagate(at);
-			_cash   .propagate(at, [&] { _payment = Payment::CASH; });
-			_card   .propagate(at, [&] { _payment = Payment::CARD; });
+			_cash   .propagate(at, [&] (Payment p) { _payment = p; });
+			_card   .propagate(at, [&] (Payment p) { _payment = p; });
 		}
 
 		void clack(Clacked_at const &at) override