ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-18 15:18:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

base: avoid use of deprecated base/printf.h

Browse Source 
Besides adapting the components to the use of base/log.h, the patch
cleans up a few base headers, i.e., it removes unused includes from
root/component.h, specifically base/heap.h and
ram_session/ram_session.h. Hence, components that relied on the implicit
inclusion of those headers have to manually include those headers now.

While adjusting the log messages, I repeatedly stumbled over the problem
that printing char * arguments is ambiguous. It is unclear whether to
print the argument as pointer or null-terminated string. To overcome
this problem, the patch introduces a new type 'Cstring' that allows the
caller to express that the argument should be handled as null-terminated
string. As a nice side effect, with this type in place, the optional len
argument of the 'String' class could be removed. Instead of supplying a
pair of (char const *, size_t), the constructor accepts a 'Cstring'.
This, in turn, clears the way let the 'String' constructor use the new
output mechanism to assemble a string from multiple arguments (and
thereby getting rid of snprintf within Genode in the near future).

To enforce the explicit resolution of the char * ambiguity, the 'char *'
overload of the 'print' function is marked as deleted.

Issue #1987
This commit is contained in:
Norman Feske
2016-07-13 19:07:09 +02:00
committed by Christian Helmuth
parent a5d3aa8373
commit 17c79a9e23
699 changed files with 5156 additions and 5865 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
repos/os/include/vfs/block_file_system.h
View File

@ -84,7 +84,7 @@ class Vfs::Block_file_system : public Single_file_system
p = _tx_source->get_acked_packet();
if (!p.succeeded()) {
PERR("Could not read block(s)");
Genode::error("Could not read block(s)");
_tx_source->release_packet(p);
return 0;
}
@ -149,7 +149,7 @@ class Vfs::Block_file_system : public Single_file_system
file_size count, file_size &out_count) override
{
if (!_writeable) {
PERR("block device is not writeable");
Genode::error("block device is not writeable");
return WRITE_ERR_INVALID;
}
@ -184,8 +184,7 @@ class Vfs::Block_file_system : public Single_file_system
nbytes = _block_io(blk_nr, (void*)(buf + written),
bytes_left, true, true);
if (nbytes == 0) {
PERR("error while write block:%llu from block device",
blk_nr);
Genode::error("error while write block:", blk_nr, " from block device");
return WRITE_ERR_INVALID;
}
@ -214,8 +213,7 @@ class Vfs::Block_file_system : public Single_file_system
nbytes = _block_io(blk_nr, _block_buffer, _block_size, true);
if ((unsigned)nbytes != _block_size) {
PERR("error while writing block:%llu from Block_device",
blk_nr);
Genode::error("error while writing block:", blk_nr, " to Block_device");
return WRITE_ERR_INVALID;
}
@ -233,7 +231,7 @@ class Vfs::Block_file_system : public Single_file_system
file_size &out_count) override
{
if (!_readable) {
PERR("block device is not readable");
Genode::error("block device is not readable");
return READ_ERR_INVALID;
}
@ -267,8 +265,7 @@ class Vfs::Block_file_system : public Single_file_system
nbytes = _block_io(blk_nr, dst + read, bytes_left, false, true);
if (nbytes == 0) {
PERR("error while reading block:%llu from block device",
blk_nr);
Genode::error("error while reading block:", blk_nr, " from block device");
return READ_ERR_INVALID;
}
@ -281,8 +278,7 @@ class Vfs::Block_file_system : public Single_file_system
nbytes = _block_io(blk_nr, _block_buffer, _block_size, false);
if ((unsigned)nbytes != _block_size) {
PERR("error while reading block:%llu from block device",
blk_nr);
Genode::error("error while reading block:", blk_nr, " from block device");
return READ_ERR_INVALID;
}
@ -314,7 +310,7 @@ class Vfs::Block_file_system : public Single_file_system
default:
PDBG("invalid ioctl request %d", opcode);
Genode::warning("invalid ioctl request ", (int)opcode);
break;
}