ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-06-19 07:38:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

udp: rename method calc_checksum update_checksum

Browse Source 
In other contexts (IPv4) 'calc_checksum' merely returns a new checksum that is
then installed via 'checksum'. Thus, the UDP 'calc_checksum' that calculates AND
installs a new checksum is misleading.

Ref #114
This commit is contained in:
Martin Stein
2016-08-15 14:42:29 +02:00
committed by Christian Helmuth
parent ee9c4679df
commit 0ce79f3a8a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
repos/os/include/net/udp.h
View File

@ -110,8 +110,8 @@ class Net::Udp_packet
* | 4 bytes | 4 bytes | 1 byte | 1 byte | 2 bytes | * | 4 bytes | 4 bytes | 1 byte | 1 byte | 2 bytes |
* -------------------------------------------------------------- * --------------------------------------------------------------
*/ */
void calc_checksum(Ipv4_address src, void update_checksum(Ipv4_address src,
Ipv4_address dst) Ipv4_address dst)
{ {
/* have to reset the checksum field for calculation */ /* have to reset the checksum field for calculation */
_checksum = 0; _checksum = 0;

2
repos/os/src/server/nic_bridge/component.cc
View File

@ -63,7 +63,7 @@ bool Session_component::handle_ip(Ethernet_frame *eth, Genode::size_t size)
Dhcp_packet(size - sizeof(Ipv4_packet) - sizeof(Udp_packet)); Dhcp_packet(size - sizeof(Ipv4_packet) - sizeof(Udp_packet));
if (dhcp->op() == Dhcp_packet::REQUEST) { if (dhcp->op() == Dhcp_packet::REQUEST) {
dhcp->broadcast(true); dhcp->broadcast(true);
udp->calc_checksum(ip->src(), ip->dst()); udp->update_checksum(ip->src(), ip->dst());
} }
} }
} }