ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-23 15:32:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

gpu/intel: avoid overlapping ggtt range allocation

Browse Source 
Size argument of ggtt free range check is ignored, which leads to
overlapping allocations inside, which leads to unavailable IO-MEM exceptions
thrown by core.

issue #4254
This commit is contained in:
Alexander Boettcher 2021-08-02 07:49:09 +02:00 committed by Christian Helmuth
parent 82a51d8eaa
commit 0aa17661cc
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
repos/os/src/drivers/gpu/intel/ggtt.h
View File

@ -88,15 +88,17 @@ class Igd::Ggtt
_array.clear(index, 1);
}
bool word_free(size_t const word) const
unsigned free_index(unsigned start_index, unsigned end_index,
size_t const num) const
{
try {
size_t const bits = sizeof(size_t) * 8;
size_t const index = word * sizeof(size_t);
return !_array.get(index, bits);
} catch (...) { }
for (unsigned index = start_index; index < end_index; index += num) {
if (index + num >= end_index)
throw Could_not_find_free();
if (!_array.get(index, num))
return index;
}
return false;
throw Could_not_find_free();
}
size_t used() const { return _used; }
@ -222,17 +224,12 @@ class Igd::Ggtt
*
* \throw Could_not_find_free
*/
Offset find_free(size_t /* num */, bool aperture = false) const
Offset find_free(size_t num, bool aperture = false) const
{
size_t const start_index = aperture ? 0 : _aperture_entries;
size_t const end_index = aperture ? _aperture_entries : _num_entries;
for (size_t i = start_index; i < end_index; i++) {
bool const f = _space.word_free(i);
if (f) { return i * (sizeof(size_t)); }
}
throw Could_not_find_free();
return _space.free_index(start_index, end_index, num);
}
/**