ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2025-04-13 06:03:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pci_decode: IRQ reporting for MSI/MSI-X only devices

Browse Source 
Don't skip IRQ reporting if legacy IRQ/GSIs are not supported as the
device may support MSI/MSI-X exclusively.

The commit also enables reserved_memory reporting of devices without
IRQs.

Ref genodelabs/genode#4578
This commit is contained in:
Christian Helmuth 2022-10-05 15:04:34 +02:00
parent 8855e5bfc9
commit 08f1f94fcb
1 changed files with 38 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
repos/os/src/app/pci_decode/main.cc
View File

@ -148,37 +148,49 @@ void Main::parse_pci_function(Bdf bdf,
});
/* IRQ pins count from 1-4 (INTA-D), zero means no IRQ defined */
if (!irq_pin)
return;
/*
* Only generate <irq> nodes if at least one of the following
* options is operational.
*
* - An IRQ pin from 1-4 (INTA-D) specifies legacy IRQ or GSI can be
* used, zero means no IRQ defined.
* - The used platform/kernel is MSI-capable and the device includes an
* MSI/MSI-X PCI capability.
*
* An <irq> node advertises (in decreasing priority) MSI-X, MSI, or
* legacy/GSI exclusively.
*/
bool const supports_irq = irq_pin != 0;
bool const supports_msi = msi_capable && (msi_x || msi);
gen.node("irq", [&]
{
if (msi_capable && msi_x) {
gen.attribute("type", "msi-x");
gen.attribute("number", msi_number++);
return;
}
if (msi_capable && msi) {
gen.attribute("type", "msi");
gen.attribute("number", msi_number++);
return;
}
if (supports_irq || supports_msi)
gen.node("irq", [&]
{
if (msi_capable && msi_x) {
gen.attribute("type", "msi-x");
gen.attribute("number", msi_number++);
return;
}
irq_line_t irq = cfg.read<Config::Irq_line>();
if (msi_capable && msi) {
gen.attribute("type", "msi");
gen.attribute("number", msi_number++);
return;
}
for_bridge(bdf.bus, [&] (Bridge & b) {
irq_routing_list.for_each([&] (Irq_routing & ir) {
ir.route(b, bdf.dev, irq_pin-1, irq); });
irq_line_t irq = cfg.read<Config::Irq_line>();
for_bridge(bdf.bus, [&] (Bridge & b) {
irq_routing_list.for_each([&] (Irq_routing & ir) {
ir.route(b, bdf.dev, irq_pin-1, irq); });
});
irq_override_list.for_each([&] (Irq_override & io) {
io.generate(gen, irq); });
gen.attribute("number", irq);
});
irq_override_list.for_each([&] (Irq_override & io) {
io.generate(gen, irq); });
gen.attribute("number", irq);
});
reserved_memory_list.for_each([&] (Rmrr & rmrr) {
if (rmrr.bdf == bdf)
gen.node("reserved_memory", [&]