ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-19 13:47:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LibC VFS: Warn on possible FD path leaks

Browse Source
This commit is contained in:
Martin Stein 2017-02-16 19:02:19 +01:00 committed by Christian Helmuth
parent 222a789fef
commit 06e605defa
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
repos/libports/include/libc-plugin/fd_alloc.h
View File

@ -49,6 +49,7 @@ namespace Libc {
void path(char const *newpath) void path(char const *newpath)
{ {
if (fd_path) { Genode::warning("may leak former FD path memory"); }
if (newpath) { if (newpath) {
Genode::size_t const path_size = ::strlen(newpath) + 1; Genode::size_t const path_size = ::strlen(newpath) + 1;
char *buf = (char*)malloc(path_size); char *buf = (char*)malloc(path_size);

1
repos/libports/src/lib/libc/vfs_plugin.h
View File

@ -66,6 +66,7 @@ class Libc::Vfs_plugin : public Libc::Plugin
* We have to allocate the path from the libc (done via 'strdup') * We have to allocate the path from the libc (done via 'strdup')
* such that the path can be freed when an stdio fd is closed. * such that the path can be freed when an stdio fd is closed.
*/ */
if (fd->fd_path) { Genode::warning("may leak former FD path memory"); }
fd->fd_path = strdup(path.string()); fd->fd_path = strdup(path.string());
} catch (Xml_node::Nonexistent_attribute) { } } catch (Xml_node::Nonexistent_attribute) { }