ExternalVendorCode/genode
1
0
Fork 0
mirror of https://github.com/genodelabs/genode.git synced 2024-12-23 15:32:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
6862ab481a
genode/base-nova/include/nova/util.h

56 lines
1.3 KiB
C
Raw Normal View History

NOVA: use cap_session to allocate portals
2012-08-08 12:23:13 +00:00
/*
* \brief Helper code used by core as base framework
* \author Alexander Boettcher
* \date 2012-08-08
*/
/*
* Copyright (C) 2012-2012 Genode Labs GmbH
*
* This file is part of the Genode OS framework, which is distributed
* under the terms of the GNU General Public License version 2.
*/
#ifndef _NOVA__INCLUDE__UTIL_H_
#define _NOVA__INCLUDE__UTIL_H_
#include <base/printf.h>
#include <base/thread.h>
NOVA: let thread die if SM cap is invalid Patch prevents following bugs: * In sleep_forever the thread return from semaphore down if cap is revoked during destruction of a thread. This causes an endless loop consuming time not available for other threads. * In lock_helper and cap_sel_alloc the thread return from the lock() method even if the semaphore down call failed because of an revoked semaphore. This lead to the situation that a thread subject to de-construction returns from the lock method, but not holding the lock, entering the critical section and modifying state inside the critical section. Another thread in parallel already in the critical section or entering the critical section also modifies the state. This lead to curious bugs ... * thread_nova, thread_start, irq_session Detect early bugs if the SM is gone unexpectedly where it should never happen.
2012-08-03 08:56:08 +00:00
__attribute__((always_inline))
inline void nova_die(const char * text = 0)
{
/*
* If thread is de-constructed the sessions are already gone.
* Be careful when enabling printf here.
NOVA: drop special utcb handling of main thread Unify handling of UTCBs. The utcb of the main thread is with commit ea38aad30e6166a0da1ac8bd84b53d6e1962cfaf at a fixed location - per convention. So we can remove all the ugly code to transfer the utcb address during process creation. To do so also the UTCB of the main thread of Core must be inside Genode's thread context area to handle it the same way. Unfortunately the UTCB of the main thread of Core can't be chosen, it is defined by the kernel. Possible solutions: - make virtual address of first thread UTCB configurable in hypervisor - map the utcb of the first thread inside Core to the desired location This commit implements the second option. Kernel patch: make utcb map-able With the patch the Utcb of the main thread of Core is map-able. Fixes #374 Noux actually uses the sp variable during thread creation and expects to be set accordingly. This wasn't the case for the main thread, it was ever set to the address of the main thread UTCB.
2012-09-28 10:24:14 +00:00
*/
while (1)
NOVA: let thread die if SM cap is invalid Patch prevents following bugs: * In sleep_forever the thread return from semaphore down if cap is revoked during destruction of a thread. This causes an endless loop consuming time not available for other threads. * In lock_helper and cap_sel_alloc the thread return from the lock() method even if the semaphore down call failed because of an revoked semaphore. This lead to the situation that a thread subject to de-construction returns from the lock method, but not holding the lock, entering the critical section and modifying state inside the critical section. Another thread in parallel already in the critical section or entering the critical section also modifies the state. This lead to curious bugs ... * thread_nova, thread_start, irq_session Detect early bugs if the SM is gone unexpectedly where it should never happen.
2012-08-03 08:56:08 +00:00
asm volatile ("ud2a" : : "a"(text));
}
NOVA: use cap_session to allocate portals
2012-08-08 12:23:13 +00:00
inline void request_event_portal(Genode::Native_capability cap,
Genode::addr_t exc_base, Genode::addr_t event)
{
using namespace Nova;
Utcb *utcb = (Utcb *)Genode::Thread_base::myself()->utcb();
/* save original receive window */
Crd orig_crd = utcb->crd_rcv;
/* request event-handler portal */
utcb->crd_rcv = Obj_crd(exc_base + event, 0);
utcb->msg[0] = event;
utcb->set_msg_word(1);
NOVA: let thread die if SM cap is invalid Patch prevents following bugs: * In sleep_forever the thread return from semaphore down if cap is revoked during destruction of a thread. This causes an endless loop consuming time not available for other threads. * In lock_helper and cap_sel_alloc the thread return from the lock() method even if the semaphore down call failed because of an revoked semaphore. This lead to the situation that a thread subject to de-construction returns from the lock method, but not holding the lock, entering the critical section and modifying state inside the critical section. Another thread in parallel already in the critical section or entering the critical section also modifies the state. This lead to curious bugs ... * thread_nova, thread_start, irq_session Detect early bugs if the SM is gone unexpectedly where it should never happen.
2012-08-03 08:56:08 +00:00
uint8_t res = call(cap.local_name());
NOVA: use cap_session to allocate portals
2012-08-08 12:23:13 +00:00
if (res)
PERR("request of event (%lu) capability selector failed",
event);
/* restore original receive window */
utcb->crd_rcv = orig_crd;
}
#endif /* _NOVA__INCLUDE__UTIL_H_ */
Reference in New Issue Copy Permalink