From ddc23aafd81f2acf7268a3fb93f64d73291fa732 Mon Sep 17 00:00:00 2001
From: cytopia <cytopia@everythingcli.org>
Date: Thu, 26 Jul 2018 09:17:57 +0200
Subject: [PATCH] Fix default file extensions for linkcheck

---
 docs/Makefile     |  2 +-
 docs/linkcheck.sh | 25 +++++++++++++++++--------
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/docs/Makefile b/docs/Makefile
index a87b067a..e29ffb07 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -49,7 +49,7 @@ help:
 
 
 linkcheck2:
-	./linkcheck.sh -r 10 -t 10 _includes/
+	./linkcheck.sh -r 10 -t 10 -e rst _includes/
 
 build:
 	sphinx-build -a -E -n -j auto -q -W . _build/html
diff --git a/docs/linkcheck.sh b/docs/linkcheck.sh
index 9f2fd5f5..24c744f6 100755
--- a/docs/linkcheck.sh
+++ b/docs/linkcheck.sh
@@ -20,7 +20,7 @@ SEARCH_PATH="."
 ###
 ### Comma separated list of file extensions to scan for urls
 ###
-EXTENSIONS="rst"
+EXTENSIONS=""
 
 
 ###
@@ -137,18 +137,27 @@ gather_urls() {
 	local reg_exclude="${3}"
 
 	local url_regex="http(s)?:\/\/[-=?:,._/#0-9a-zA-Z]+"
+	local find_ext=
 	local find_cmd=
 
-	find_cmd="find ${path} \( -iname \*.${extensions//,/ -o -iname \\*.} \) -exec grep -Eo '${url_regex}' {} \;"
+	if [ -n "${extensions}" ]; then
+		find_ext="\( -iname \*.${extensions//,/ -o -iname \\*.} \)"
+	fi
+
+	find_cmd="find ${path} ${find_ext} -type f -exec grep --binary-files=without-match -Eo '${url_regex}' '{}' \;"
+	>&2 echo "\$ ${find_cmd}"
 
 	# Loop through uniqued URLs
-	for url in $(eval "${find_cmd}" | sort -u); do
-		# Remove any trailing: [,.]
-		url="$( echo "${url}" | sed 's/[,.]$//g')"
+	for url in $(eval "${find_cmd}" 2>/dev/null | sort -u); do
+		# Ignore any 'Binary file...' results
+		if echo "${url}" | grep -Eq '^htt'; then
+			# Remove any trailing: [,.]
+			url="$( echo "${url}" | sed 's/[,.]$//g')"
 
-		# Ignore URLs excluded by regex
-		if ! echo "${url}" | grep -qE "${reg_exclude}"; then
-			echo "${url}"
+			# Ignore URLs excluded by regex
+			if ! echo "${url}" | grep -qE "${reg_exclude}"; then
+				echo "${url}"
+			fi
 		fi
 	done
 }