crosstool-ng/kconfig
Masahiro Yamada eef8eb4033 kconfig: display recursive dependency resolution hint just once
Commit 1c199f2878f6 ("kbuild: document recursive dependency limitation
/ resolution") probably intended to show a hint along with "recursive
dependency detected!" error, but it missed to add {...} guard, and the
hint is displayed in every loop of the dep_stack traverse, annoyingly.

This error was detected by GCC's -Wmisleading-indentation when switching
to build-time generation of lexer/parser.

scripts/kconfig/symbol.c: In function ‘sym_check_print_recursive’:
scripts/kconfig/symbol.c:1150:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   if (stack->sym == last_sym)
   ^~
scripts/kconfig/symbol.c:1153:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
    fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n");
    ^~~~~~~

I could simply add {...} to surround the three fprintf(), but I rather
chose to move the hint after the loop to make the whole message readable.

Fixes: 1c199f2878f6 ("kbuild: document recursive dependency limitation / resolution"
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>

[upstream commit e3b03bf29d6b99fab7001fb20c33fe54928c157a]
Fixes #1000
Signed-off-by: Chris Packham <judge.packham@gmail.com>
2018-07-10 14:25:20 +12:00
..
lxdialog Merge steps.mk into ct-ng 2018-04-07 12:03:17 -07:00
.gitignore Merge steps.mk into ct-ng 2018-04-07 12:03:17 -07:00
check.sh Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
conf.c Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
confdata.c kconfig: sync upstream changes 2016-11-30 16:34:39 -08:00
expr.c Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
expr.h Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
kconf_id.c Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
list.h Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
lkc_proto.h Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
lkc.h Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
Makefile.am Supply explicit --tag CC 2018-04-13 21:36:59 -07:00
mconf.c kconfig: Update kconfig. Sync with Linux-4.2 2015-09-03 19:00:28 -07:00
menu.c Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
nconf.c Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
nconf.gui.c Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00
nconf.h kconfig: Update kconfig. Sync with Linux-4.2 2015-09-03 19:00:28 -07:00
symbol.c kconfig: display recursive dependency resolution hint just once 2018-07-10 14:25:20 +12:00
util.c kconfig: Update kconfig. Sync with Linux-4.2 2015-09-03 19:00:28 -07:00
zconf.l kconfig: Add updates from linux-4.3 and 4.4 2015-11-11 21:27:24 -08:00
zconf.y Sync kconfig files with upstream 4.15 2018-01-31 16:39:45 -08:00