ExternalVendorCode/crosstool-ng
1
0
Fork 0
mirror of https://github.com/crosstool-ng/crosstool-ng.git synced 2025-06-16 06:18:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use 'chmod a-x' instead of 'chmod -x'

Browse Source 
There is a subtle difference when executable bit is a part of the umask.
And at least some versions (Debian/stretch) fail if the resulting mode
would've been different if not for the umask setting.

Fixes #998.

Although, with such chmods/umasks it is likely that some package installation
will break anyway. But I'll leave it until somebody complains.

Signed-off-by: Alexey Neyman <stilor@att.net>
This commit is contained in:
Alexey Neyman
2018-09-26 23:54:55 -07:00
parent 29f0662c18
commit d573c15758
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Makefile.am
View File

@ -65,10 +65,10 @@ bash-completion/ct-ng: bash-completion/ct-ng.in Makefile
install-data-hook: install-data-hook:
rm -f $(DESTDIR)$(man1dir)/$(ctng_progname).1.gz rm -f $(DESTDIR)$(man1dir)/$(ctng_progname).1.gz
gzip -9 $(DESTDIR)$(man1dir)/$(ctng_progname).1 gzip -9 $(DESTDIR)$(man1dir)/$(ctng_progname).1
chmod +x $(DESTDIR)$(pkgdatadir)/scripts/config.guess chmod a+x $(DESTDIR)$(pkgdatadir)/scripts/config.guess
chmod +x $(DESTDIR)$(pkgdatadir)/scripts/config.sub chmod a+x $(DESTDIR)$(pkgdatadir)/scripts/config.sub
if INSTALL_BASH_COMPLETION if INSTALL_BASH_COMPLETION
chmod -x $(DESTDIR)$(compdir)/$(ctng_progname) chmod a-x $(DESTDIR)$(compdir)/$(ctng_progname)
endif endif
uninstall-hook: uninstall-hook:

2
scripts/build/binutils/binutils.sh
View File

@ -223,7 +223,7 @@ do_binutils_backend() {
sed -r -e "s/@@DEFAULT_LD@@/${CT_BINUTILS_LINKER_DEFAULT}/" \ sed -r -e "s/@@DEFAULT_LD@@/${CT_BINUTILS_LINKER_DEFAULT}/" \
"${CT_LIB_DIR}/scripts/build/binutils/binutils-ld.in" \ "${CT_LIB_DIR}/scripts/build/binutils/binutils-ld.in" \
>"${prefix}/bin/${CT_TARGET}-ld" >"${prefix}/bin/${CT_TARGET}-ld"
chmod +x "${prefix}/bin/${CT_TARGET}-ld" chmod a+x "${prefix}/bin/${CT_TARGET}-ld"
cp -a "${prefix}/bin/${CT_TARGET}-ld" \ cp -a "${prefix}/bin/${CT_TARGET}-ld" \
"${prefix}/${CT_TARGET}/bin/ld" "${prefix}/${CT_TARGET}/bin/ld"

2
scripts/build/debug/300-gdb.sh
View File

@ -315,7 +315,7 @@ do_debug_gdb_build() {
# Workaround for bad versions, where the configure # Workaround for bad versions, where the configure
# script for gdbserver is not executable... # script for gdbserver is not executable...
# Bah, GNU folks strike again... :-( # Bah, GNU folks strike again... :-(
chmod +x "${gdb_src_dir}/gdb/gdbserver/configure" chmod a+x "${gdb_src_dir}/gdb/gdbserver/configure"
gdbserver_extra_config=("${extra_config[@]}") gdbserver_extra_config=("${extra_config[@]}")

2
testing/docker/archlinux/Dockerfile
View File

@ -1,3 +1,3 @@
FROM hoverbear/archlinux FROM base/archlinux:latest
RUN pacman -Syu --noconfirm RUN pacman -Syu --noconfirm
RUN pacman -S --noconfirm base-devel git help2man python unzip RUN pacman -S --noconfirm base-devel git help2man python unzip

2
testing/docker/dmgr.sh
View File

@ -109,7 +109,7 @@ action_clean()
msg "Cleaning up after ${cntr}" msg "Cleaning up after ${cntr}"
if [ -d build-${cntr} ]; then if [ -d build-${cntr} ]; then
chmod -R +w build-${cntr} chmod -R a+w build-${cntr}
rm -rf build-${cntr} rm -rf build-${cntr}
fi fi
} }

2
testing/docker/gentoo-amd64/Dockerfile
View File

@ -1,4 +1,4 @@
FROM gentoo/stage3-amd64-hardened FROM gentoo/stage3-amd64-hardened
RUN wget -O /sbin/dumb-init https://github.com/Yelp/dumb-init/releases/download/v1.2.1/dumb-init_1.2.1_amd64 RUN wget -O /sbin/dumb-init https://github.com/Yelp/dumb-init/releases/download/v1.2.1/dumb-init_1.2.1_amd64
RUN chmod +x /sbin/dumb-init RUN chmod a+x /sbin/dumb-init
ENTRYPOINT [ "/sbin/dumb-init", "--" ] ENTRYPOINT [ "/sbin/dumb-init", "--" ]