newlib: Add upstream patches for float support

Bring in upstream support for newer float standards being used by GCC.

Fixes #1957
Signed-off-by: Chris Packham <judge.packham@gmail.com>
This commit is contained in:
Chris Packham 2023-05-28 14:31:41 +12:00
parent df2c7559fa
commit 72e07cce8f
2 changed files with 115 additions and 0 deletions

View File

@ -0,0 +1,50 @@
From 91f99d323b39dc0c06c40038791db9861d4b76b9 Mon Sep 17 00:00:00 2001
From: Kito Cheng <kito.cheng@sifive.com>
Date: Mon, 12 Jul 2021 17:17:21 +0800
Subject: [PATCH] Minimal support for ISO/IEC TS 18661-3.
- GCC will set __FLT_EVAL_METHOD__ to 16 if __fp16 supported, e.g.
cortex-a55/aarch64.
- $ aarch64-unknown-elf-gcc -v 2>&1 |grep version
gcc version 9.2.0 (GCC)
- $ aarch64-unknown-elf-gcc -E -dM -mcpu=cortex-a55 - < /dev/null |grep FLT_EVAL_METHOD
#define __FLT_EVAL_METHOD__ 16
#define __FLT_EVAL_METHOD_TS_18661_3__ 16
#define __FLT_EVAL_METHOD_C99__ 16
- The behavior of __FLT_EVAL_METHOD__ == 16 is same as
__FLT_EVAL_METHOD__ == 0 except for float16_t, but newlib didn't
support float16_t.
ISO/IEC TS 18661-3:
http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2405.pdf
V2 Changes:
- List Howland, Craig D as co-author since he provide the draft of comment
in math.h.
Co-authored-by: "Howland, Craig D" <howland@LGSInnovations.com>
---
newlib/libc/include/math.h | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
--- a/newlib/libc/include/math.h
+++ b/newlib/libc/include/math.h
@@ -146,7 +146,17 @@
#define __TMP_FLT_EVAL_METHOD
#endif /* FLT_EVAL_METHOD */
#if defined FLT_EVAL_METHOD
- #if FLT_EVAL_METHOD == 0
+/* FLT_EVAL_METHOD == 16 has meaning as defined in ISO/IEC TS 18661-3,
+ * which provides non-compliant extensions to C and POSIX (by adding
+ * additional positive values for FLT_EVAL_METHOD). It effectively has
+ * same meaning as the C99 and C11 definitions for value 0, while also
+ * serving as a flag that the _Float16 (float16_t) type exists.
+ *
+ * FLT_EVAL_METHOD could be any number of bits of supported floating point
+ * format (e.g. 32, 64, 128), but currently only AArch64 and few other targets
+ * might define that as 16. */
+ #if (FLT_EVAL_METHOD == 0) \
+ || (FLT_EVAL_METHOD == 16)
typedef float float_t;
typedef double double_t;
#elif FLT_EVAL_METHOD == 1

View File

@ -0,0 +1,65 @@
From 27f0913c17c216548b2f5eea79037ee90038f375 Mon Sep 17 00:00:00 2001
From: Andrea Corallo <andrea.corallo@arm.com>
Date: Wed, 30 Mar 2022 15:40:59 +0200
Subject: [PATCH] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0,
1, 2
2022-03-30 Andrea Corallo <andrea.corallo@arm.com>
* libc/include/machine/ieeefp.h (__FLOAT_TYPE, __DOUBLE_TYPE): New
macros.
* libc/include/math.h: Uses __DOUBLE_TYPE __FLOAT_TYPE to define
double_t float_t if possible.
---
newlib/libc/include/machine/ieeefp.h | 14 ++++++++++++++
newlib/libc/include/math.h | 9 +++++++++
2 files changed, 23 insertions(+)
--- a/newlib/libc/include/machine/ieeefp.h
+++ b/newlib/libc/include/machine/ieeefp.h
@@ -90,6 +90,13 @@
#ifndef __SOFTFP__
# define _SUPPORTS_ERREXCEPT
#endif
+/* As per ISO/IEC TS 18661 '__FLT_EVAL_METHOD__' will be defined to 16
+ (if compiling with +fp16 support) so it can't be used by math.h to
+ define float_t and double_t. For values of '__FLT_EVAL_METHOD__'
+ other than 0, 1, 2 the definition of float_t and double_t is
+ implementation-defined. */
+#define __DOUBLE_TYPE double
+#define __FLOAT_TYPE float
#endif
#if defined (__aarch64__)
@@ -102,6 +109,13 @@
#ifdef __ARM_FP
# define _SUPPORTS_ERREXCEPT
#endif
+/* As per ISO/IEC TS 18661 '__FLT_EVAL_METHOD__' will be defined to 16
+ (if compiling with +fp16 support) so it can't be used by math.h to
+ define float_t and double_t. For values of '__FLT_EVAL_METHOD__'
+ other than 0, 1, 2 the definition of float_t and double_t is
+ implementation-defined. */
+#define __DOUBLE_TYPE double
+#define __FLOAT_TYPE float
#endif
#ifdef __epiphany__
--- a/newlib/libc/include/math.h
+++ b/newlib/libc/include/math.h
@@ -168,6 +168,15 @@
#else
/* Implementation-defined. Assume float_t and double_t have been
* defined previously for this configuration (e.g. config.h). */
+
+ /* If __DOUBLE_TYPE is defined (__FLOAT_TYPE is then supposed to be
+ defined as well) float_t and double_t definition is suggested by
+ an arch specific header. */
+ #ifdef __DOUBLE_TYPE
+ typedef __DOUBLE_TYPE double_t;
+ typedef __FLOAT_TYPE float_t;
+ #endif
+ /* Assume config.h has provided these types. */
#endif
#else
/* Assume basic definitions. */