2016-02-05 21:09:51 +00:00
|
|
|
From 6c7c5c477ef9ccf2d2548cf2ac3cec9bd3c9c5b6 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Max Filippov <jcmvbkbc@gmail.com>
|
|
|
|
|
Date: Tue, 2 Feb 2016 17:11:38 +0300
|
|
|
|
|
Subject: [PATCH] xtensa: fix signedness of gas relocations
|
|
|
|
|
|
|
|
|
|
Change 1058c7532d0b "Use signed data type for R_XTENSA_DIFF* relocation
|
|
|
|
|
offsets." changed signedness of BFD_RELOC_XTENSA_DIFF* relocations
|
|
|
|
|
substituted for BFD_RELOC_*. This made it impossible to encode arbitrary
|
|
|
|
|
8-, 16- and 32-bit values, which broke e.g. debug info encoding by .loc
|
|
|
|
|
directive. Revert this part and add test.
|
|
|
|
|
|
|
|
|
|
gas/
|
|
|
|
|
2016-02-03 Max Filippov <jcmvbkbc@gmail.com>
|
|
|
|
|
* config/tc-xtensa.c (md_apply_fix): Mark BFD_RELOC_XTENSA_DIFF*
|
|
|
|
|
substitutions for BFD_RELOC_* as unsigned.
|
|
|
|
|
* gas/testsuite/gas/xtensa/all.exp: Add loc to list of xtensa
|
|
|
|
|
tests.
|
|
|
|
|
* gas/testsuite/gas/xtensa/loc.d: New file: loc test result
|
|
|
|
|
patterns.
|
|
|
|
|
* gas/testsuite/gas/xtensa/loc.s: New file: loc test.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
|
|
|
|
|
---
|
2017-12-02 20:44:39 +00:00
|
|
|
gas/config/tc-xtensa.c | 6 +++---
|
|
|
|
|
gas/testsuite/gas/xtensa/all.exp | 1 +
|
|
|
|
|
gas/testsuite/gas/xtensa/loc.d | 10 ++++++++++
|
|
|
|
|
gas/testsuite/gas/xtensa/loc.s | 7 +++++++
|
2016-02-05 21:09:51 +00:00
|
|
|
4 files changed, 21 insertions(+), 3 deletions(-)
|
|
|
|
|
create mode 100644 gas/testsuite/gas/xtensa/loc.d
|
|
|
|
|
create mode 100644 gas/testsuite/gas/xtensa/loc.s
|
|
|
|
|
|
|
|
|
|
--- a/gas/config/tc-xtensa.c
|
|
|
|
|
+++ b/gas/config/tc-xtensa.c
|
2017-12-02 20:44:39 +00:00
|
|
|
@@ -5961,15 +5961,15 @@
|
2016-02-05 21:09:51 +00:00
|
|
|
{
|
|
|
|
|
case BFD_RELOC_8:
|
|
|
|
|
fixP->fx_r_type = BFD_RELOC_XTENSA_DIFF8;
|
|
|
|
|
- fixP->fx_signed = 1;
|
|
|
|
|
+ fixP->fx_signed = 0;
|
|
|
|
|
break;
|
|
|
|
|
case BFD_RELOC_16:
|
|
|
|
|
fixP->fx_r_type = BFD_RELOC_XTENSA_DIFF16;
|
|
|
|
|
- fixP->fx_signed = 1;
|
|
|
|
|
+ fixP->fx_signed = 0;
|
|
|
|
|
break;
|
|
|
|
|
case BFD_RELOC_32:
|
|
|
|
|
fixP->fx_r_type = BFD_RELOC_XTENSA_DIFF32;
|
|
|
|
|
- fixP->fx_signed = 1;
|
|
|
|
|
+ fixP->fx_signed = 0;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
--- a/gas/testsuite/gas/xtensa/all.exp
|
|
|
|
|
+++ b/gas/testsuite/gas/xtensa/all.exp
|
2017-12-02 20:44:39 +00:00
|
|
|
@@ -101,6 +101,7 @@
|
2016-02-05 21:09:51 +00:00
|
|
|
run_dump_test "trampoline"
|
|
|
|
|
run_dump_test "first_frag_align"
|
|
|
|
|
run_dump_test "auto-litpools"
|
|
|
|
|
+ run_dump_test "loc"
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if [info exists errorInfo] then {
|
|
|
|
|
--- /dev/null
|
|
|
|
|
+++ b/gas/testsuite/gas/xtensa/loc.d
|
|
|
|
|
@@ -0,0 +1,10 @@
|
|
|
|
|
+#as:
|
|
|
|
|
+#objdump: -r
|
|
|
|
|
+#name: .loc directive relocs
|
|
|
|
|
+
|
|
|
|
|
+.*: +file format .*xtensa.*
|
|
|
|
|
+
|
|
|
|
|
+RELOCATION RECORDS FOR \[\.debug_line\]:
|
|
|
|
|
+#...
|
|
|
|
|
+.*R_XTENSA_DIFF16.*\.text\+0x00009c42
|
|
|
|
|
+#...
|
|
|
|
|
--- /dev/null
|
|
|
|
|
+++ b/gas/testsuite/gas/xtensa/loc.s
|
|
|
|
|
@@ -0,0 +1,7 @@
|
|
|
|
|
+ .text
|
|
|
|
|
+ .file 1 "loc.s"
|
|
|
|
|
+ .loc 1 3
|
|
|
|
|
+ nop
|
|
|
|
|
+ .space 40000
|
|
|
|
|
+ .loc 1 5
|
|
|
|
|
+ nop
|
