mirror of
https://github.com/corda/corda.git
synced 2025-02-06 02:59:15 +00:00
2fa6b5a208
* CORDA-3769: Switched attachments class loader cache to use caffeine with original implementation used by determinstic core. * CORDA-3769: Removed default ctor arguments. * CORDA-3769: Switched mapping function to Function type to avoid synthetic method being generated. * CORDA-3769: Now using a cache created from NamedCacheFactory for the attachments class loader cache. * CORDA-3769: Making detekt happy. * CORDA-3769: The finality tests now check for UntrustedAttachmentsException which will actually happen in reality. * CORDA-3769: Refactored after review comments. * CORDA-3769: Removed the AttachmentsClassLoaderSimpleCacheImpl as DJVM does not need it. Also updated due to review comments. * CORDA-3769: Removed the generic parameters from AttachmentsClassLoader. * CORDA-3769: Removed unused imports. * CORDA-3769: Updates from review comments. * CORDA-3769: Updated following review comments. MigrationServicesForResolution now uses cache factory. Ctor updated for AttachmentsClassLoaderSimpleCacheImpl. * CORDA-3769: Reduced max class loader cache size * CORDA-3769: Fixed the attachments class loader cache size to a fixed default * CORDA-3769: Switched attachments class loader size to be reduced by fixed value.
Adding tests to the Core module
TL;DR: Any tests that do not require further dependencies should be added to this module, anything that
requires additional Corda dependencies needs to go into core-tests.
The Corda core module defines a lot of types and helpers that can only be exercised, and therefore tested, in
the context of a node. However, as everything else depends on the core module, we cannot pull the node into
this module. Therefore, any tests that require further Corda dependencies need to be defined in the module
core-tests, which has the full set of dependencies including node-driver.