Commit Graph

7314 Commits

Author SHA1 Message Date
Tudor Malene
34184ca1ea CORDA-2465 Address code review comments. 2019-02-13 15:51:57 +00:00
Mike Hearn
b65ebdd116
Merge pull request #4747 from corda/feature/CORDA-2570/revert-to-one-attachment-per-contract
CORDA-2570 revert multiple contract attachments per transaction
2019-02-13 16:42:30 +01:00
Tudor Malene
e4ae1a2aaa CORDA-2465 Address code review comments. 2019-02-13 15:27:02 +00:00
tudor.malene@gmail.com
0d1765ad0e Merge branch 'master' into feature/CORDA-2465/document_whitelist_migration
# Conflicts:
#	docs/source/api-contract-constraints.rst
2019-02-13 14:59:04 +00:00
Andrius Dagys
b0eb85b4cf DOCS - Changelog typo fix (#4649) 2019-02-13 14:00:02 +00:00
Tudor Malene
3fef5d8239 CORDA-2570 Add comment for future performance optimisation. 2019-02-13 13:42:42 +00:00
Tudor Malene
fc0b1431ad CORDA-2570 fix KDoc 2019-02-13 13:30:37 +00:00
tudor.malene@gmail.com
00ddb5793d Merge branch 'master' into feature/CORDA-2570/revert-to-one-attachment-per-contract
# Conflicts:
#	core/src/main/kotlin/net/corda/core/internal/TransactionVerifierServiceInternal.kt
#	core/src/test/kotlin/net/corda/core/contracts/ConstraintsPropagationTests.kt
2019-02-13 13:10:28 +00:00
Tudor Malene
764b33ded5 CORDA-2570 address code review comments 2019-02-13 12:17:48 +00:00
szymonsztuka
10e7c07c11
CORDA-2577 Disable or delete the no-downgrade rule (#4741)
With (Contract JARs) rolling upgrades the downgrade rule cannot be effectively check as the platform can't tell the difference between a transaction that's downgrading because of an attack, vs a transaction that's downgrading because Alice has upgraded but Bob hasn't yet. During a rolling upgrade we would expect state versions to fluctuate up and down as data gets read/written by a mix of nodes. With the feature as implemented Alice will upgrade and start trading with Bob. Bob will be able to read and process the states Alice sent him, but the moment he tries to consume such a state he will fail. This will result in cascading flow deaths and a hung business network the moment an upgrade starts.
2019-02-13 11:36:43 +00:00
Tudor Malene
4a4788ad41 CORDA-2570 fix test 2019-02-13 10:58:28 +00:00
Joel Dudley
873e9a5442
Updates docs to match new cordapp-example structure. (#4748) 2019-02-13 07:37:27 +00:00
Tudor Malene
9448b9bd86 CORDA-2570 revert multiple contract attachments per transaction 2019-02-12 18:49:05 +00:00
Tudor Malene
a6510ae952 CORDA-2570 revert multiple contract attachments per transaction 2019-02-12 18:41:45 +00:00
Mike Hearn
db41f660e0
Merge pull request #4737 from corda/mike-docs-4.0-tweaks
Docs: fix various issues for C4.
2019-02-12 16:47:15 +01:00
rogersanick
7723887d5e Adding final grammatical / content changes suggested by RBG. 2019-02-12 10:35:11 -05:00
Anthony Keenan
8cec8182a4
Revert "DOCS - correct command docs for clear network map cache (#4677)" (#4732)
This reverts commit 0a50d76ab1.
2019-02-12 15:24:34 +00:00
JamesHR3
4e2a295eb6
[CORDA-2487] Provide a migration for vault states when moving from V3 to V4.1 (#4699)
* Create a new custom migration for populating the state_party table and the relevancy_status column within the vault_states table when migrating from V3 to V4.

* Add a corresponding unit test suite.

* Small refactorings to expose data required by the migration: the isRelevant function in the NodeVaultService, and the node's legal name from the configuration.
2019-02-12 15:22:15 +00:00
Mike Hearn
a0bcfe3fd4 Docs: address review comments from Richard. 2019-02-12 15:21:44 +01:00
Mike Hearn
46188598c4
Merge pull request #4556 from corda/updatesToAPISTATESdocs
Updates to API-State docs (StatePointers)
2019-02-12 12:29:33 +01:00
Mike Hearn
2e7b2f64ff
Merge pull request #4710 from corda/carolynequinn-UAT-additions
Adding new page on UAT environment
2019-02-12 12:27:27 +01:00
Dimos Raptis
59719a8a61
[CORDA-2420] - Make boundary of public API explicit in docs (#4735) 2019-02-12 10:04:16 +00:00
Mike Hearn
ca49c5e94d Docs: fix various issues for C4.
- Delete information about hash->signature constraint migration. That
  won't work for C4.0
- Rewrite parts of the api-contract-constraints.rst file to fix grammar
  problems and reduce the weight of the page. Some detail isn't really
  necessary at this point in the docs.
- Mention more things in the upgrade notes.
2019-02-11 20:02:06 +01:00
Mike Hearn
64cbe9f904
Merge pull request #4734 from corda/mike-simplify-migration
CORDA-2545: Merge PNO check rework to master.
2019-02-11 19:04:30 +01:00
Mike Hearn
f541843eff Temporary workaround for a bug that was exposed by a refactoring. Will follow up with a fix in another PR. 2019-02-11 17:10:50 +01:00
Mike Hearn
55f4071050 Make API checker happy 2019-02-11 17:10:50 +01:00
Mike Hearn
02645f7b9e Rework package namespace ownership check to verify every package of every class file.
Previous implementation was in LedgerTransaction and focused only on contract classes,
but every package matters.

Also fixes some exception types and does misc refactorings.
2019-02-11 17:10:50 +01:00
Chris Rankin
b9ecc5243f Tell ProGuard to remove FlowLogic and ProgressTracker classes. 2019-02-11 17:10:50 +01:00
Mike Hearn
0a9f4c68ae Minor refactorings.
Take out a useless parameter from a method that was added to the public
API, document it. Add some comments explaining more about why we are
looking up attachment versions in WireTransaction.toLedgerTransaction.
2019-02-11 17:10:50 +01:00
Mike Hearn
5f70abfeca
Merge pull request #4731 from corda/mike-update-coding-guidelines
Add a section to the coding guidelines about updating the docsite.
2019-02-11 16:59:08 +01:00
Stefano Franz
9581370a9c improve docker image and allow automatically restarting node after --initial-registration 2019-02-11 15:17:57 +00:00
Stefano Franz
7252c84a5a address review comments re: resusing variables 2019-02-11 15:17:57 +00:00
Stefano Franz
ebce04a8b1 add example network
add ability to specify RPC password during config generation
2019-02-11 15:17:57 +00:00
Mike Hearn
2074718e7d Add a section to the coding guidelines about updating the docsite. 2019-02-11 16:15:05 +01:00
carolynequinn
18a1d93e6d
Update UAT.md 2019-02-11 10:56:02 +00:00
Chris Rankin
329caa20b7
CORDA-2564: Ensure that corda-serialization uses @JvmDefault for interfaces. (#4725) 2019-02-08 17:20:40 +00:00
Thomas Schroeter
cdac97120a
[CORDA-2547] Migrate table of SimpleNotaryService (#4722)
* CORDA-2547: WIP Migrate old notary schema correctly.

Modify liquibase scripts to rename the old committed state table instead of creating a new one.

* Rename liquibase change sets

* Change 3.3 baseline before Liquibase.

* Aligin with ENT, orginal node-notary.changelog-v1.xml moved to node-notary.changelog-v2.xml and it's compatible with ENT (which already has changes from v2).

* Aligin with ENT, orginal node-notary.changelog-v1.xml moved to node-notary.changelog-v2.xml and it's compatible with ENT (which already has changes from v2) - adding v2 to master file.

* Ensure setting up Liquibase on pre-existing pre-Liquibase database
2019-02-08 16:30:02 +00:00
Katarzyna Streich
f729453fee CORDA-2334 - Net Params non-downgrade verification in transaction resolution / building. (#4351)
* Add FetchParametersFlow

* No downgrade parameters in ResolveTransactionsFlow

Make sure that parameters in the transaction
graph are ordered (this is to prevent the downgrade attack, when the
malicious notary and participants sign transaction that shouldn't be
notarised otherwise). We ensure that by checking that epochs of network
parameters in the transaction chain are ordered.

* Addressed some minor items from RP review feedback.

* Refactoring following rebase from master.

* Address RP PR review comments (round 2)

* Addressed a couple of minor PR review points.

* Renaming of unit tests and cleanup.

* Changes discusses with RP to ensure Network Param checking is applied at txn verify time + resolve order checking gated on existence of tagged NPs in txn and associated minimum platform version.

* Do not fail on missing ServiceHub impl + return nothing if txn not NP tagged.

* Unify HistoricNetworkParametersStorage and
NetworkParametersStorageInternal

* SignedDataWithCert implements NamedByHash

* Cleanup

* Move parameters ordering check to signed transaction resolution

* Fixes after merge, address comments

* Address Andrius comments
2019-02-08 15:29:32 +00:00
josecoll
db35f73bcc
Remove old reference to publishing a single corda finance jar. (#4704) 2019-02-07 18:33:20 +00:00
josecoll
0c33d2fd9d
CORDA-2514 Constraints checking failures do not provide indication of cause (#4638) (#4688)
* Add logging to constraints checking to indicate reason of failure.

* Additional debug logging message.
2019-02-07 18:32:42 +00:00
Dimos Raptis
49fb03bf6b
Fix documentation issues (#4721) 2019-02-06 12:49:47 +00:00
Cais Manai
0e770bbb85
Merge pull request #4705 from corda/cais-docs-cordapp-tutorial
Updating the docs for tutorial cordapp to reflect Spring Boot changes
2019-02-06 11:13:24 +00:00
Roger Willis
0360a33e5c
State pointers are always resolved, so the kdocs should reflect this. (#4716) 2019-02-06 09:52:11 +00:00
Chris Rankin
7866dde91b
CORDA-2556: Refactor World City database into a library module. (#4718)
* Refactor World City database into a library module.
* Migrate CityDatabaseTest into worldmap module.
2019-02-05 15:29:26 +00:00
Dominic Fox
6cdd9f96b8 CORDA-2423 document draining requirements in flow state machines (#4707)
* CORDA-2423 document draining requirements in flow state machines

* Expand and move to warning block

* Add warning to hello-world-flow.rst
2019-02-05 14:19:08 +00:00
szymonsztuka
bb0ceda8d0 Addressing PR comments - added links to jarSigner and corda-gradle-plugins signing and explain which one to use. 2019-02-05 11:49:30 +00:00
carolynequinn
bf2881ca29
Adding new page on UAT environment
We need to have an external page which talks about UAT, as agreed with marketing this should be on docs.corda.net rather than elsewhere. 

The idea is that this cannot be corda.network since UAT is part of R3, not the Foundation.
2019-02-04 09:46:29 +00:00
Shams Asari
c667df9bec
Port over ENT changes (#4706)
Port of commit 9b55ad2680
2019-02-01 18:10:10 +00:00
Shams Asari
c39c61ecab
CORDA-2467: Moved non-contract things out of finance-contracts and into finance-workflows (#4700)
This includes all of the cash selection logic, JSON support using jackson and a bunch of utilities which are not relevant to contract verification. The exception to this are Interpolator which has been moved to the IRS demo, and PhysicalLocationStructures.kt which is now in explorer.
2019-02-01 17:31:12 +00:00
CaisR3
5c38cb3aaf minor fixes including the splitting of finance jar into contracts and workflows 2019-02-01 16:14:16 +00:00