ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2024-12-28 00:38:55 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix leak by executing acks on the messaging executor

Browse Source
This commit is contained in:
Andras Slemmer 2017-12-07 15:18:03 +00:00
parent b3ca36132f
commit fcdb669042
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
node/src/main/kotlin/net/corda/node/services/messaging/P2PMessagingClient.kt
View File

@ -294,12 +294,14 @@ class P2PMessagingClient(config: NodeConfiguration,
// processing a message but if so, it'll be parked waiting for us to count down the latch, so // processing a message but if so, it'll be parked waiting for us to count down the latch, so
// the session itself is still around and we can still ack messages as a result. // the session itself is still around and we can still ack messages as a result.
override fun acknowledge() { override fun acknowledge() {
messagingExecutor.fetchFrom {
state.locked { state.locked {
artemisMessage.individualAcknowledge() artemisMessage.individualAcknowledge()
artemis.started!!.session.commit() artemis.started!!.session.commit()
} }
} }
} }
}
deliverTo(msg, HandlerRegistration(msg.topic, deliverTo), acknowledgeHandle) deliverTo(msg, HandlerRegistration(msg.topic, deliverTo), acknowledgeHandle)
} else { } else {
log.warn("Received message ${msg.uniqueMessageId} for ${msg.topic} that doesn't have any registered handlers yet") log.warn("Received message ${msg.uniqueMessageId} for ${msg.topic} that doesn't have any registered handlers yet")