From fb70c4b69ca7b1dd98d23b1b57c356f897f866ee Mon Sep 17 00:00:00 2001 From: Shams Asari Date: Tue, 22 May 2018 11:38:56 +0100 Subject: [PATCH] Marked createComponentGroups as @CordaInternal (#3193) --- .ci/api-current.txt | 2 -- .../kotlin/net/corda/core/transactions/WireTransaction.kt | 4 +++- docs/source/changelog.rst | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.ci/api-current.txt b/.ci/api-current.txt index f3aa7f91ab..7225772d13 100644 --- a/.ci/api-current.txt +++ b/.ci/api-current.txt @@ -5178,8 +5178,6 @@ public final class net.corda.core.transactions.WireTransaction extends net.corda public static final net.corda.core.transactions.WireTransaction$Companion Companion ## public static final class net.corda.core.transactions.WireTransaction$Companion extends java.lang.Object - @NotNull - public final java.util.List createComponentGroups(java.util.List, java.util.List>, java.util.List>, java.util.List, net.corda.core.identity.Party, net.corda.core.contracts.TimeWindow) ## public final class net.corda.core.utilities.ByteArrays extends java.lang.Object @NotNull diff --git a/core/src/main/kotlin/net/corda/core/transactions/WireTransaction.kt b/core/src/main/kotlin/net/corda/core/transactions/WireTransaction.kt index 0e0d98dbe8..cc59e541e4 100644 --- a/core/src/main/kotlin/net/corda/core/transactions/WireTransaction.kt +++ b/core/src/main/kotlin/net/corda/core/transactions/WireTransaction.kt @@ -1,5 +1,6 @@ package net.corda.core.transactions +import net.corda.core.CordaInternal import net.corda.core.contracts.* import net.corda.core.contracts.ComponentGroupEnum.* import net.corda.core.crypto.* @@ -226,11 +227,12 @@ class WireTransaction(componentGroups: List, val privacySalt: Pr sig.verify(id) } - internal companion object { + companion object { /** * Creating list of [ComponentGroup] used in one of the constructors of [WireTransaction] required * for backwards compatibility purposes. */ + @CordaInternal fun createComponentGroups(inputs: List, outputs: List>, commands: List>, diff --git a/docs/source/changelog.rst b/docs/source/changelog.rst index 480420b936..8b5a3ea5fb 100644 --- a/docs/source/changelog.rst +++ b/docs/source/changelog.rst @@ -7,6 +7,9 @@ release, see :doc:`upgrade-notes`. Unreleased ========== +* ``WireTransaction.Companion.createComponentGroups`` has been marked as ``@CordaInternal``. It was never intended to be + public and was already internal for Kotlin code. + * RPC Framework moved from Kryo to the Corda AMQP implementation [Corda-847]. This completes the removal of ``Kryo`` from general use within Corda, remaining only for use in flow checkpointing.