Consistent database columns naming convention. (#2043)

* Consistent database column naming convention.
* Remove a column length constraint in NodeAttachmentService.

node/src/main/kotlin/net/corda/node/services/identity/PersistentIdentityService.kt

@@ -78,7 +78,7 @@ class PersistentIdentityService(identities: Iterable<PartyAndCertificate> = empt
             var publicKeyHash: String = "",
 
             @Lob
-            @Column
+            @Column(name = "identity_value")
             var identity: ByteArray = ByteArray(0)
     )
 

node/src/main/kotlin/net/corda/node/services/persistence/DBCheckpointStorage.kt

@@ -23,7 +23,7 @@ class DBCheckpointStorage : CheckpointStorage {
             var checkpointId: String = "",
 
             @Lob
-            @Column(name = "checkpoint")
+            @Column(name = "checkpoint_value")
             var checkpoint: ByteArray = ByteArray(0)
     )
 

node/src/main/kotlin/net/corda/node/services/persistence/DBTransactionStorage.kt

@@ -22,7 +22,7 @@ class DBTransactionStorage : WritableTransactionStorage, SingletonSerializeAsTok
             var txId: String = "",
 
             @Lob
-            @Column
+            @Column(name = "transaction_value")
             var transaction: ByteArray = ByteArray(0)
     )
 

node/src/main/kotlin/net/corda/node/services/persistence/NodeAttachmentService.kt

@@ -39,7 +39,7 @@ class NodeAttachmentService(metrics: MetricRegistry) : AttachmentStorage, Single
             indexes = arrayOf(Index(name = "att_id_idx", columnList = "att_id")))
     class DBAttachment(
             @Id
-            @Column(name = "att_id", length = 65535)
+            @Column(name = "att_id")
             var attId: String,
 
             @Column(name = "content")

node/src/main/kotlin/net/corda/node/services/transactions/RaftUniquenessProvider.kt

@@ -70,7 +70,7 @@ class RaftUniquenessProvider(private val transportConfiguration: NodeSSLConfigur
     @Table(name = "notary_committed_states")
     class RaftState(
             @Id
-            @Column
+            @Column(name = "id")
             var key: String = "",
 
             @Lob

node/src/test/kotlin/net/corda/node/services/schema/NodeSchemaServiceTest.kt

@@ -87,7 +87,7 @@ object TestSchema : MappedSchema(SchemaFamily::class.java, 1, setOf(Parent::clas
     @Table(name = "Children")
     class Child {
         @Id
-        @GeneratedValue(strategy = GenerationType.IDENTITY)
+        @GeneratedValue
         @Column(name = "child_id", unique = true, nullable = false)
         var childId: Int? = null