Merge pull request #161 from soc/topic/SIOOBE

Add StringIndexOutOfBoundsException and use it in String

classpath/java/lang/String.java

@@ -10,13 +10,14 @@
 
 package java.lang;
 
+import java.io.Serializable;
 import java.io.UnsupportedEncodingException;
-import java.util.regex.Pattern;
 import java.util.Comparator;
 import java.util.Locale;
-import java.io.Serializable;
+import java.util.regex.Pattern;
-import avian.Utf8;
+
 import avian.Iso88591;
+import avian.Utf8;
 
 public final class String
   implements Comparable<String>, CharSequence, Serializable
@@ -28,6 +29,7 @@ public final class String
 
   public static Comparator<String> CASE_INSENSITIVE_ORDER
     = new Comparator<String>() {
+    @Override
     public int compare(String a, String b) {
       return a.compareToIgnoreCase(b);
     }
@@ -88,10 +90,12 @@ public final class String
   }
 
   public String(byte bytes[], int highByte, int offset, int length) {
-    if (offset < 0 || offset + length > bytes.length) {
+    if (offset < 0 )
-      throw new IndexOutOfBoundsException
+      throw new StringIndexOutOfBoundsException(offset);
-        (offset + " < 0 or " + offset + " + " + length + " > " + bytes.length);
+    else if (offset + length > bytes.length)
-    }
+      throw new StringIndexOutOfBoundsException(offset + length);
+    else if (length < 0)
+      throw new StringIndexOutOfBoundsException(length);
 
     char[] c = new char[length];
     int mask = highByte << 8;
@@ -112,10 +116,12 @@ public final class String
       l = ((byte[]) data).length;
     }
 
-    if (offset < 0 || offset + length > l) {
+    if (offset < 0 )
-      throw new IndexOutOfBoundsException
+      throw new StringIndexOutOfBoundsException(offset);
-        (offset + " < 0 or " + offset + " + " + length + " > " + l);
+    else if (offset + length > l)
-    }
+      throw new StringIndexOutOfBoundsException(offset + length);
+    else if (length < 0)
+      throw new StringIndexOutOfBoundsException(length);
 
     if(!copy && Utf8.test(data)) copy = true;
 
@@ -144,14 +150,17 @@ public final class String
     }
   }
 
+  @Override
   public String toString() {
     return this;
   }
 
+  @Override
   public int length() {
     return length;
   }
 
+  @Override
   public int hashCode() {
     if (hashCode == 0) {
       int h = 0;
@@ -161,6 +170,7 @@ public final class String
     return hashCode;
   }
 
+  @Override
   public boolean equals(Object o) {
     if (this == o) {
       return true;
@@ -172,17 +182,15 @@ public final class String
     }
   }
 
-  public boolean equalsIgnoreCase(String o) {
+  public boolean equalsIgnoreCase(String s) {
-    if (this == o) {
+    if (this == s) {
       return true;
-    } else if (o instanceof String) {
-      String s = (String) o;
-      return s.length == length && compareToIgnoreCase(s) == 0;
     } else {
-      return false;
+      return s.length == length && compareToIgnoreCase(s) == 0;
     }
   }
 
+  @Override
   public int compareTo(String s) {
     if (this == s) return 0;
 
@@ -367,18 +375,20 @@ public final class String
   }
 
   public String substring(int start, int end) {
-    if (start >= 0 && end >= start && end <= length) {
+    if (start < 0)
-      if (start == 0 && end == length) {
+      throw new StringIndexOutOfBoundsException(start);
+    else if (end > length)
+      throw new StringIndexOutOfBoundsException(end);
+    int newLen = end - start;
+    if (newLen < 0)
+      throw new StringIndexOutOfBoundsException(newLen);
+
+    if (start == 0 && end == length)
       return this;
-      } else if (end - start == 0) {
+    else if (end - start == 0)
       return "";
-      } else  {
+    else
-        return new String(data, offset + start, end - start, false);
+      return new String(data, offset + start, newLen, false);
-      }
-    } else {
-      throw new IndexOutOfBoundsException
-        (start + " not in [0, " + end + ") or " + end + " > " + length);
-    }
   }
 
   public boolean startsWith(String s) {
@@ -416,9 +426,12 @@ public final class String
   public void getBytes(int srcOffset, int srcLength,
                        byte[] dst, int dstOffset)
   {
-    if (srcOffset < 0 || srcOffset + srcLength > length) {
+    if (srcOffset < 0)
-      throw new IndexOutOfBoundsException();
+      throw new StringIndexOutOfBoundsException(srcOffset);
-    }
+    else if (srcOffset + srcLength > length)
+      throw new StringIndexOutOfBoundsException(srcOffset + srcLength);
+    else if (srcLength < 0)
+      throw new StringIndexOutOfBoundsException(srcLength);
 
     if (data instanceof char[]) {
       char[] src = (char[]) data;
@@ -462,9 +475,11 @@ public final class String
   public void getChars(int srcOffset, int srcEnd,
                        char[] dst, int dstOffset)
   {
-    if (srcOffset < 0 || srcEnd > length) {
+    if (srcOffset < 0)
-      throw new IndexOutOfBoundsException();
+      throw new StringIndexOutOfBoundsException(srcOffset);
-    }
+    else if (srcEnd > length)
+      throw new StringIndexOutOfBoundsException(srcEnd);
+
     int srcLength = srcEnd-srcOffset;
     if (data instanceof char[]) {
       char[] src = (char[]) data;
@@ -483,9 +498,10 @@ public final class String
     return b;
   }
 
+  @Override
   public char charAt(int index) {
     if (index < 0 || index > length) {
-      throw new IndexOutOfBoundsException();
+      throw new StringIndexOutOfBoundsException(index);
     }
 
     if (data instanceof char[]) {
@@ -503,6 +519,7 @@ public final class String
     return Pattern.compile(regex).split(this, limit);
   }
 
+  @Override
   public CharSequence subSequence(int start, int end) {
     return substring(start, end);
   }

classpath/java/lang/StringIndexOutOfBoundsException.java

@@ -0,0 +1,19 @@
+package java.lang;
+
+/**
+ * Used by <code>String</code> to signal that a given index is either less than
+ * or greater than the allowed range.
+ */
+public class StringIndexOutOfBoundsException extends IndexOutOfBoundsException {
+  private static final long serialVersionUID = -6762910422159637258L;
+
+  public StringIndexOutOfBoundsException(int index) {
+    super("String index out of range: "+index);
+  }
+
+  public StringIndexOutOfBoundsException(String message) {
+	super(message);
+  }
+
+  public StringIndexOutOfBoundsException() {}
+}