From ea0a108cd220379ca1505c4d1393475387b3602e Mon Sep 17 00:00:00 2001 From: Joel Dice Date: Mon, 29 Dec 2014 12:16:28 -0700 Subject: [PATCH] add todo comment regarding integer division --- src/codegen/target/arm/assembler.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/codegen/target/arm/assembler.cpp b/src/codegen/target/arm/assembler.cpp index c9ddec0cc1..5d36fdf2f6 100644 --- a/src/codegen/target/arm/assembler.cpp +++ b/src/codegen/target/arm/assembler.cpp @@ -570,6 +570,11 @@ class MyArchitecture : public Architecture { aMask.typeMask = bMask.typeMask = lir::Operand::RegisterPairMask; break; + // todo: Although ARM has instructions for integer division and + // remainder, they don't trap on division by zero, which is why + // we use thunks. Alternatively, we could generate inline code + // with an explicit zero check, which would probably be a bit + // faster. case lir::Divide: case lir::Remainder: case lir::FloatRemainder: